Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flattener: handle comments without crashing #296

Merged
1 commit merged into from
Nov 9, 2023
Merged

Flattener: handle comments without crashing #296

1 commit merged into from
Nov 9, 2023

Conversation

ghost
Copy link

@ghost ghost commented Nov 9, 2023

@ghost ghost requested a review from akmiller01 November 9, 2023 10:46
@ghost ghost self-assigned this Nov 9, 2023
akmiller01
akmiller01 approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@akmiller01 akmiller01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. There are a surprising number of comments in IATI XML.

@ghost ghost merged commit c09fc21 into develop Nov 9, 2023
@ghost ghost deleted the 2023-11-09 branch November 9, 2023 12:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akmiller01 @jarofgreen