Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge develop into main #301

Closed
wants to merge 29 commits into from
Closed

Merge develop into main #301

wants to merge 29 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 28, 2023

No description provided.

James (ODSC) and others added 29 commits October 10, 2023 16:27
Merge pull request #285 from IATI/develop
Tests: lakify recursive_json_nest function
Add inner text to lakify recursive_json_nest function
Tests come from existing Postman tests
…test

JS & Python parse broken XML differently.
In historic_date_format_empty_multivalue.input.xml - the
      <result type="1">
markup is broken as it is never closed.
However JS and Python assume different names for following elements in this case.

Move broken element to end of <iati-activity >
That way we will still test the broken XML parsing,
but the names will match what is in the expected file now.
…from arrays

This functionality in the old system will not be copied to the new system.
It was used to rebuild transactions and budgets, but the rebuilding logic was flawed
and we will be switching to a different way

#267
This mirrors old system
#267

Also, if python exception occurs when flatenning, mark that doc as in error
and let other docs carry on.
Use new Flattener class directly, stop using external service.
#266

We keep using utils.get_hash_for_identifier for now
to preserve old behavoir as much as possible
and to make sure id's are in a format acceptable to Solr
Fix: If 2 transactions/budgets are exactly the same, they are merged
Flattener - include microseconds to 3 places, not just zero's
Flattener: handle comments without crashing
Now xsd:date with time zones are correctly parsed

#267
Add parse_xsd_date_value - use in Flattener
@ghost ghost self-assigned this Nov 28, 2023
@ghost
Copy link
Author

ghost commented Nov 29, 2023

Not releasing yet, need small bug fix

@ghost ghost closed this Nov 29, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants