-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge develop into main #301
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #285 from IATI/develop
Tests: lakify recursive_json_nest function
Edgecase XML file for lakify
…t upon failing to find text
Add inner text to lakify recursive_json_nest function
Tests come from existing Postman tests
…test JS & Python parse broken XML differently. In historic_date_format_empty_multivalue.input.xml - the <result type="1"> markup is broken as it is never closed. However JS and Python assume different names for following elements in this case. Move broken element to end of <iati-activity > That way we will still test the broken XML parsing, but the names will match what is in the expected file now.
…from arrays This functionality in the old system will not be copied to the new system. It was used to rebuild transactions and budgets, but the rebuilding logic was flawed and we will be switching to a different way #267
Will be used for #267
This mirrors old system
2023 10 18
#267 Also, if python exception occurs when flatenning, mark that doc as in error and let other docs carry on.
Use new Flattener class directly, stop using external service.
#266 We keep using utils.get_hash_for_identifier for now to preserve old behavoir as much as possible and to make sure id's are in a format acceptable to Solr
Fix: If 2 transactions/budgets are exactly the same, they are merged
Flattener - include microseconds to 3 places, not just zero's
Flattener: handle comments without crashing
2023 11 14
Now xsd:date with time zones are correctly parsed #267
Add parse_xsd_date_value - use in Flattener
ghost
self-assigned this
Nov 28, 2023
Not releasing yet, need small bug fix |
ghost
closed this
Nov 29, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.