Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go to 1.23 #57

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

ade18
Copy link

@ade18 ade18 commented Nov 19, 2024

Update go to 1.21 to remediate crypto/tls vulnerability

@ade18
Copy link
Author

ade18 commented Nov 19, 2024

#58

@ade18 ade18 force-pushed the update_go_version branch from bcc3d78 to b8f711d Compare November 19, 2024 13:25
@ade18
Copy link
Author

ade18 commented Nov 19, 2024

@SANJEEV-Choubey Please can you review

Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM golang:1.19-alpine as builder
FROM golang:1.21-alpine as builder
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could upgrade go version to 1.23

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

go.mod Outdated
@@ -1,19 +1,19 @@
module github.com/IBM-Cloud/redli

go 1.19
go 1.21
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if you could upgrade go version to 1.23

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@SANJEEV-Choubey
Copy link
Collaborator

@ade18 Thank you very much for your time and for creating this PR.Could below two things will be taken care?

  • Upgrade to Go 1.23
  • Get rid of /vendor

@ade18 ade18 force-pushed the update_go_version branch from b8f711d to 7a6df6b Compare December 13, 2024 17:08
@ade18 ade18 force-pushed the update_go_version branch from 7a6df6b to 87d6db0 Compare December 13, 2024 17:11
@ade18
Copy link
Author

ade18 commented Dec 13, 2024

@ade18 Thank you very much for your time and for creating this PR.Could below two things will be taken care?

  • Upgrade to Go 1.23
  • Get rid of /vendor

Thank you for reviewing, i have made the changes. @SANJEEV-Choubey

@SANJEEV-Choubey
Copy link
Collaborator

Could you also get rid of vendor and start using the module?

@ade18
Copy link
Author

ade18 commented Dec 15, 2024

Could you also get rid of vendor and start using the module?
@SANJEEV-Choubey
The vendor folder has been removed, its appearing like this in my commit because it has always been there in the repo , see https://github.com/IBM-Cloud/redli/tree/master/vendor . Please can you explain what you mean by " using this module" ?

@SANJEEV-Choubey
Copy link
Collaborator

Could you also get rid of vendor and start using the module?
@SANJEEV-Choubey
The vendor folder has been removed, its appearing like this in my commit because it has always been there in the repo , see https://github.com/IBM-Cloud/redli/tree/master/vendor . Please can you explain what you mean by " using this module" ?

@ade18 As we use go mod so now go/vendor is not required, As you are updating go version it would be great we should only use modules in this PR otherwise a operate PR will be needed to remove vendor.

Action Item:- Delete vendor directory from this repo and Build and test it if it is working fine please update the PR and upload a test evidence.

@ade18
Copy link
Author

ade18 commented Dec 15, 2024

Could you also get rid of vendor and start using the module?
@SANJEEV-Choubey
The vendor folder has been removed, its appearing like this in my commit because it has always been there in the repo , see https://github.com/IBM-Cloud/redli/tree/master/vendor . Please can you explain what you mean by " using this module" ?

@ade18 As we use go mod so now go/vendor is not required, As you are updating go version it would be great we should only use modules in this PR otherwise a operate PR will be needed to remove vendor.

Action Item:- Delete vendor directory from this repo and Build and test it if it is working fine please update the PR and upload a test evidence.

@SANJEEV-Choubey the vendor directory is deleted in this PR thats why there is over 300+ files appearing being removed from the repository including the directory itself. You can navidate to my forked repo/branch and will see its indeed removed as shown in the PR.

See evidences

Compiling the code

Screenshot 2024-12-15 at 22 29 16

See image being built:

Screenshot 2024-12-15 at 22 32 28

@SANJEEV-Choubey SANJEEV-Choubey changed the title Update go to 1.21 Update go to 1.23 Dec 16, 2024
Copy link
Collaborator

@SANJEEV-Choubey SANJEEV-Choubey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SANJEEV-Choubey SANJEEV-Choubey merged commit 9434bdb into IBM-Cloud:master Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants