Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Cloud Databases): Database user password complexity validation #4931

Merged
merged 16 commits into from
Nov 29, 2023
Merged

feat(Cloud Databases): Database user password complexity validation #4931

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b36bc46
feat(Cloud Databases): Database user password complexity validation
Nov 16, 2023
5c72c00
update secrets
Nov 16, 2023
18571fe
update tests to conform to new complexity rules
Nov 16, 2023
6ac093a
Merge remote-tracking branch 'upstream/master' into cdb-password-comp…
Nov 17, 2023
352af86
support go 1.18
Nov 17, 2023
0e4b074
fix password validation edgecases
Nov 17, 2023
eef99ef
add test case for password beginning with special char
Nov 17, 2023
e0e84a0
fix regexp
Nov 18, 2023
972df9c
refactor of db users
Nov 22, 2023
4b28142
Merge branch 'master' into cdb-password-complexity
alexhemard Nov 22, 2023
3321d00
remove debug logs
Nov 22, 2023
492bf2b
Merge branch 'master' into cdb-password-complexity
alexhemard Nov 23, 2023
69b10b8
delete and create ops manager users when updating
Nov 29, 2023
8cbb46c
Merge remote-tracking branch 'origin/cdb-password-complexity' into cd…
Nov 29, 2023
e1584ed
validate adminpassword, update docs
Nov 29, 2023
0e4cceb
update secrets
Nov 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
134 changes: 88 additions & 46 deletions .secrets.baseline
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"files": "go.mod|go.sum|.*.map|^.secrets.baseline$",
"lines": null
},
"generated_at": "2023-11-10T20:51:53Z",
"generated_at": "2023-11-22T15:05:51Z",
"plugins_used": [
{
"name": "AWSKeyDetector"
Expand Down Expand Up @@ -760,23 +760,23 @@
"hashed_secret": "731438016c5ab94431f61820f35e3ae5f8ad6004",
"is_secret": false,
"is_verified": false,
"line_number": 412,
"line_number": 416,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "12da2e35d6b50c902c014f1ab9e3032650368df7",
"is_secret": false,
"is_verified": false,
"line_number": 418,
"line_number": 422,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "813274ccae5b6b509379ab56982d862f7b5969b6",
"is_secret": false,
"is_verified": false,
"line_number": 1123,
"line_number": 1127,
"type": "Base64 High Entropy String",
"verified_result": null
}
Expand Down Expand Up @@ -846,15 +846,15 @@
"hashed_secret": "da8cae6284528565678de15e03d461e23fe22538",
"is_secret": false,
"is_verified": false,
"line_number": 1845,
"line_number": 1858,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "1a0334cfa65f4be58b9d914b8e96e9d9478bfbac",
"is_secret": false,
"is_verified": false,
"line_number": 3226,
"line_number": 3239,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down Expand Up @@ -1268,15 +1268,7 @@
"hashed_secret": "3046d9f6cfaaeea6eed9bb7a4ab010fe49b0cfd4",
"is_secret": false,
"is_verified": false,
"line_number": 129,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "505032eaf8a3acf9b094a326dfb1cd0537c75a0d",
"is_secret": false,
"is_verified": false,
"line_number": 235,
"line_number": 104,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down Expand Up @@ -1364,15 +1356,7 @@
"hashed_secret": "3046d9f6cfaaeea6eed9bb7a4ab010fe49b0cfd4",
"is_secret": false,
"is_verified": false,
"line_number": 94,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "505032eaf8a3acf9b094a326dfb1cd0537c75a0d",
"is_secret": false,
"is_verified": false,
"line_number": 364,
"line_number": 68,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down Expand Up @@ -2014,7 +1998,7 @@
"hashed_secret": "884a58e4c2c5d195d3876787bdc63af6c5af2924",
"is_secret": false,
"is_verified": false,
"line_number": 1589,
"line_number": 1595,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down Expand Up @@ -2072,38 +2056,38 @@
"hashed_secret": "deab23f996709b4e3d14e5499d1cc2de677bfaa8",
"is_secret": false,
"is_verified": false,
"line_number": 1357,
"line_number": 1331,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "20a25bac21219ffff1904bde871ded4027eca2f8",
"is_secret": false,
"is_verified": false,
"line_number": 1944,
"line_number": 1919,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "b732fb611fd46a38e8667f9972e0cde777fbe37f",
"is_secret": false,
"is_verified": false,
"line_number": 1963,
"line_number": 1938,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "1f5e25be9b575e9f5d39c82dfd1d9f4d73f1975c",
"is_secret": false,
"is_verified": false,
"line_number": 2203,
"line_number": 2142,
"type": "Secret Keyword",
"verified_result": null
}
],
"ibm/service/database/resource_ibm_database_cassandra_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 731,
Expand All @@ -2113,7 +2097,7 @@
],
"ibm/service/database/resource_ibm_database_edb_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 205,
Expand All @@ -2123,7 +2107,7 @@
],
"ibm/service/database/resource_ibm_database_elasticsearch_platinum_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 823,
Expand All @@ -2133,7 +2117,7 @@
],
"ibm/service/database/resource_ibm_database_elasticsearch_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 778,
Expand All @@ -2143,7 +2127,7 @@
],
"ibm/service/database/resource_ibm_database_etcd_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 213,
Expand All @@ -2153,15 +2137,15 @@
],
"ibm/service/database/resource_ibm_database_mongodb_enterprise_test.go": [
{
"hashed_secret": "68ab9ef0953865fef0558010a9f7afcef110d5b8",
"hashed_secret": "8cbbbfad0206e5953901f679b0d26d583c4f5ffe",
"is_secret": false,
"is_verified": false,
"line_number": 271,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 336,
Expand All @@ -2179,7 +2163,7 @@
"verified_result": null
},
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 189,
Expand All @@ -2189,7 +2173,7 @@
],
"ibm/service/database/resource_ibm_database_mongodb_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 214,
Expand All @@ -2199,7 +2183,7 @@
],
"ibm/service/database/resource_ibm_database_mysql_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 150,
Expand All @@ -2209,15 +2193,15 @@
],
"ibm/service/database/resource_ibm_database_postgresql_test.go": [
{
"hashed_secret": "e407cbe1c64cadb886be6f42907e2dd1c06ca080",
"hashed_secret": "728e83f156932be9b1dc48a5c3f7a3bfbeeb08ce",
"is_secret": false,
"is_verified": false,
"line_number": 490,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 658,
Expand All @@ -2227,7 +2211,7 @@
],
"ibm/service/database/resource_ibm_database_rabbitmq_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 223,
Expand All @@ -2237,14 +2221,72 @@
],
"ibm/service/database/resource_ibm_database_redis_test.go": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 272,
"type": "Secret Keyword",
"verified_result": null
}
],
"ibm/service/database/resource_ibm_database_test.go": [
{
"hashed_secret": "c237978e1983e0caf1c3a84f1c2e72a7fb2981f2",
"is_secret": false,
"is_verified": false,
"line_number": 19,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "d67007844d8f7fbc45ea3b27c4bea0bffafb53a0",
"is_secret": false,
"is_verified": false,
"line_number": 27,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "279fb854eb9fa001b4629518a45c921cfad6d697",
"is_secret": false,
"is_verified": false,
"line_number": 35,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "dad6fac3e5b6be7bb6f274970b4c50739a7e26ee",
"is_secret": false,
"is_verified": false,
"line_number": 59,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "8cbbbfad0206e5953901f679b0d26d583c4f5ffe",
"is_secret": false,
"is_verified": false,
"line_number": 67,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "f5ecb30890399c7b1d1781583478aaa9d0b0c89d",
"is_secret": false,
"is_verified": false,
"line_number": 91,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "6da9eab371358a331c59a76d80a0ffcd589fe3c9",
"is_secret": false,
"is_verified": false,
"line_number": 101,
"type": "Secret Keyword",
"verified_result": null
}
],
"ibm/service/directlink/resource_ibm_dl_provider_gateway_test.go": [
{
"hashed_secret": "a184c8ba0974f2e1da4ca1d71f54e1cf40604335",
Expand Down Expand Up @@ -2940,7 +2982,7 @@
"hashed_secret": "3c2ecad9b250fd6d99893e4d05ec02ca19aa95d0",
"is_secret": false,
"is_verified": false,
"line_number": 383,
"line_number": 389,
"type": "Secret Keyword",
"verified_result": null
}
Expand Down Expand Up @@ -4227,15 +4269,15 @@
],
"website/docs/r/database.html.markdown": [
{
"hashed_secret": "10c28f9cf0668595d45c1090a7b4a2ae98edfa58",
"hashed_secret": "2317aa72dafa0a07f05af47baa2e388f95dcf6f3",
"is_secret": false,
"is_verified": false,
"line_number": 494,
"type": "Secret Keyword",
"verified_result": null
},
{
"hashed_secret": "e407cbe1c64cadb886be6f42907e2dd1c06ca080",
"hashed_secret": "ddf75a48487b387b1dc328ac0a942377b377c556",
"is_secret": false,
"is_verified": false,
"line_number": 559,
Expand Down
2 changes: 1 addition & 1 deletion ibm/service/codeengine/resource_ibm_code_engine_domain_mapping_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ func testAccCheckIbmCodeEngineDomainMappingDestroy(s *terraform.State) error {
func decodeBase64EnvVar(base64Text string, envVar string) string {
decodedText, err := base64.StdEncoding.DecodeString(base64Text)
if err != nil {
fmt.Printf("Error decoding environment variable %s: %s", envVar, err)
// fmt.Errorf("Error decoding environment variable %s: %s", envVar, err)
return ""
}
return string(decodedText)
Expand Down
Loading
Loading