-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Quality Transform: update readme and add sample notebook #790
Open
dtsuzuku-ibm
wants to merge
9
commits into
dev
Choose a base branch
from
update-doc_quality-readme
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+258
−10
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
1a70530
update readme following template https://github.com/IBM/data-prep-kit…
dtsuzuku-ibm ecb87b0
fix typo and update description
dtsuzuku-ibm e3fae5d
add name/email of contributor
dtsuzuku-ibm 170af4b
first version of a notebook
shahrokhDaijavad 10851f6
fixed code_location
shahrokhDaijavad 7545872
add link to jupyter notebook
dtsuzuku-ibm 9ee506e
update notebook
dtsuzuku-ibm cf13388
stop installing data-prep-connector
dtsuzuku-ibm edb605b
use data-prep-toolkit-transforms==0.2.2.dev3
dtsuzuku-ibm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,207 @@ | ||
| { | ||
| "cells": [ | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "afd55886-5f5b-4794-838e-ef8179fb0394", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "##### **** These pip installs need to be adapted to use the appropriate release level. Alternatively, The venv running the jupyter lab could be pre-configured with a requirement file that includes the right release. Example for transform developers working from git clone:\n", | ||
| "```\n", | ||
| "make venv \n", | ||
| "source venv/bin/activate \n", | ||
| "pip install jupyterlab\n", | ||
| "```" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 1, | ||
| "id": "4c45c3c6-e4d7-4e61-8de6-32d61f2ce695", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "%%capture\n", | ||
| "## This is here as a reference only\n", | ||
| "# Users and application developers must use the right tag for the latest from pypi\n", | ||
| "%pip install data-prep-toolkit\n", | ||
| "%pip install data-prep-toolkit-transforms==0.2.2.dev3" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "407fd4e4-265d-4ec7-bbc9-b43158f5f1f3", | ||
| "metadata": { | ||
| "jp-MarkdownHeadingCollapsed": true | ||
| }, | ||
| "source": [ | ||
| "##### **** Configure the transform parameters. The set of dictionary keys holding DocQualityTransform configuration for values are as follows: \n", | ||
| "* text_lang - specifies language used in the text content. By default, \"en\" is used.\n", | ||
| "* doc_content_column - specifies column name that contains document text. By default, \"contents\" is used.\n", | ||
| "* bad_word_filepath - specifies a path to bad word file: local folder (file or directory) that points to bad word file. You don't have to set this parameter if you don't need to set bad words.\n", | ||
| "#####" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "ebf1f782-0e61-485c-8670-81066beb734c", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "##### ***** Import required classes and modules" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 2, | ||
| "id": "c2a12abc-9460-4e45-8961-873b48a9ab19", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "import os\n", | ||
| "import sys\n", | ||
| "\n", | ||
| "from data_processing.runtime.pure_python import PythonTransformLauncher\n", | ||
| "from data_processing.utils import ParamsUtils\n", | ||
| "from doc_quality_transform import (bad_word_filepath_cli_param, doc_content_column_cli_param, text_lang_cli_param,)\n", | ||
| "from doc_quality_transform_python import DocQualityPythonTransformConfiguration" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "7234563c-2924-4150-8a31-4aec98c1bf33", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "##### ***** Setup runtime parameters for this transform" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 3, | ||
| "id": "e90a853e-412f-45d7-af3d-959e755aeebb", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "\n", | ||
| "# create parameters\n", | ||
| "input_folder = os.path.join(\"python\", \"test-data\", \"input\")\n", | ||
| "output_folder = os.path.join( \"python\", \"output\")\n", | ||
| "local_conf = {\n", | ||
| " \"input_folder\": input_folder,\n", | ||
| " \"output_folder\": output_folder,\n", | ||
| "}\n", | ||
| "code_location = {\"github\": \"github\", \"commit_hash\": \"12345\", \"path\": \"path\"}\n", | ||
| "params = {\n", | ||
| " # Data access. Only required parameters are specified\n", | ||
| " \"data_local_config\": ParamsUtils.convert_to_ast(local_conf),\n", | ||
| " # execution info\n", | ||
| " \"runtime_pipeline_id\": \"pipeline_id\",\n", | ||
| " \"runtime_job_id\": \"job_id\",\n", | ||
| " \"runtime_code_location\": ParamsUtils.convert_to_ast(code_location),\n", | ||
| " # doc_quality params\n", | ||
| " text_lang_cli_param: \"en\",\n", | ||
| " doc_content_column_cli_param: \"contents\",\n", | ||
| " bad_word_filepath_cli_param: os.path.join(\"python\", \"ldnoobw\", \"en\"),\n", | ||
| "}" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "7949f66a-d207-45ef-9ad7-ad9406f8d42a", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "##### ***** Use python runtime to invoke the transform" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 4, | ||
| "id": "0775e400-7469-49a6-8998-bd4772931459", | ||
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "name": "stderr", | ||
| "output_type": "stream", | ||
| "text": [ | ||
| "12:39:07 INFO - doc_quality parameters are : {'text_lang': 'en', 'doc_content_column': 'contents', 'bad_word_filepath': 'python/ldnoobw/en', 's3_cred': None, 'docq_data_factory': <data_processing.data_access.data_access_factory.DataAccessFactory object at 0x12ae67650>}\n", | ||
| "12:39:07 INFO - pipeline id pipeline_id\n", | ||
| "12:39:07 INFO - code location {'github': 'github', 'commit_hash': '12345', 'path': 'path'}\n", | ||
| "12:39:07 INFO - data factory data_ is using local data access: input_folder - python/test-data/input output_folder - python/output\n", | ||
| "12:39:07 INFO - data factory data_ max_files -1, n_sample -1\n", | ||
| "12:39:07 INFO - data factory data_ Not using data sets, checkpointing False, max files -1, random samples -1, files to use ['.parquet'], files to checkpoint ['.parquet']\n", | ||
| "12:39:07 INFO - orchestrator docq started at 2024-11-25 12:39:07\n", | ||
| "12:39:07 INFO - Number of files is 1, source profile {'max_file_size': 0.0009870529174804688, 'min_file_size': 0.0009870529174804688, 'total_file_size': 0.0009870529174804688}\n", | ||
| "12:39:07 INFO - Load badwords found locally from python/ldnoobw/en\n", | ||
| "12:39:09 INFO - Completed 1 files (100.0%) in 0.033 min\n", | ||
| "12:39:09 INFO - Done processing 1 files, waiting for flush() completion.\n", | ||
| "12:39:09 INFO - done flushing in 0.0 sec\n", | ||
| "12:39:09 INFO - Completed execution in 0.033 min, execution result 0\n" | ||
| ] | ||
| } | ||
| ], | ||
| "source": [ | ||
| "%%capture\n", | ||
| "sys.argv = ParamsUtils.dict_to_req(d=params)\n", | ||
| "launcher = PythonTransformLauncher(runtime_config=DocQualityPythonTransformConfiguration())\n", | ||
| "launcher.launch()" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "markdown", | ||
| "id": "c3df5adf-4717-4a03-864d-9151cd3f134b", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "##### **** The specified folder will include the transformed parquet files." | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": 5, | ||
| "id": "7276fe84-6512-4605-ab65-747351e13a7c", | ||
| "metadata": {}, | ||
| "outputs": [ | ||
| { | ||
| "data": { | ||
| "text/plain": [ | ||
| "['python/output/metadata.json', 'python/output/test1.parquet']" | ||
| ] | ||
| }, | ||
| "execution_count": 5, | ||
| "metadata": {}, | ||
| "output_type": "execute_result" | ||
| } | ||
| ], | ||
| "source": [ | ||
| "import glob\n", | ||
| "glob.glob(\"python/output/*\")" | ||
| ] | ||
| }, | ||
| { | ||
| "cell_type": "code", | ||
| "execution_count": null, | ||
| "id": "845a75cf-f4a9-467d-87fa-ccbac1c9beb8", | ||
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [] | ||
| } | ||
| ], | ||
| "metadata": { | ||
| "kernelspec": { | ||
| "display_name": ".venv", | ||
| "language": "python", | ||
| "name": "python3" | ||
| }, | ||
| "language_info": { | ||
| "codemirror_mode": { | ||
| "name": "ipython", | ||
| "version": 3 | ||
| }, | ||
| "file_extension": ".py", | ||
| "mimetype": "text/x-python", | ||
| "name": "python", | ||
| "nbconvert_exporter": "python", | ||
| "pygments_lexer": "ipython3", | ||
| "version": "3.11.0" | ||
| } | ||
| }, | ||
| "nbformat": 4, | ||
| "nbformat_minor": 5 | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,25 @@ | ||
| # Document Quality Transform | ||
|
|
||
| Please see the set of | ||
| [transform project conventions](../../../README.md#transform-project-conventions) | ||
| for details on general project conventions, transform configuration, | ||
| testing and IDE set up. | ||
|
|
||
| ## Summary | ||
| This transform will calculate and annotate several metrics related to document, which are usuful to see the quality of document. | ||
| ## Contributors | ||
|
|
||
| - Daiki Tsuzuku ([email protected]) | ||
|
|
||
| ## Description | ||
| This transform will calculate and annotate several metrics which are useful to assess the quality of the document. | ||
| The document quality transform operates on text documents only | ||
|
|
||
| ### Input | ||
|
|
||
| In this transform, following metrics will be included: | ||
| | input column name | data type | description | | ||
| |-|-|-| | ||
| | the one specified in _doc_content_column_ configuration | string | text whose quality will be calculated by this transform | | ||
agoyal26 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| ### Output columns annotated by this transform | ||
|
|
||
| | output column name | data type | description | supported language | | ||
| |-|-|-|-| | ||
|
|
@@ -27,7 +39,7 @@ In this transform, following metrics will be included: | |
|
|
||
| You can see more detailed backgrounds of some columns in [Deepmind's Gopher paper](https://arxiv.org/pdf/2112.11446.pdf) | ||
|
|
||
| ## Configuration and command line Options | ||
| ## Configuration | ||
|
|
||
| The set of dictionary keys holding [DocQualityTransform](src/doc_quality_transform.py) | ||
| configuration for values are as follows: | ||
|
|
@@ -36,13 +48,19 @@ configuration for values are as follows: | |
| * _doc_content_column_ - specifies column name that contains document text. By default, "contents" is used. | ||
| * _bad_word_filepath_ - specifies a path to bad word file: local folder (file or directory) that points to bad word file. You don't have to set this parameter if you don't need to set bad words. | ||
|
|
||
| ## Running | ||
| Example | ||
| ``` | ||
| { | ||
| text_lang_key: "en", | ||
| doc_content_column_key: "contents", | ||
| bad_word_filepath_key: os.path.join(basedir, "ldnoobw", "en"), | ||
| } | ||
| ``` | ||
|
|
||
| ## Usage | ||
|
|
||
| ### Launched Command Line Options | ||
| When running the transform with the Ray launcher (i.e. TransformLauncher), | ||
| the following command line arguments are available in addition to | ||
| the options provided by | ||
| the [python launcher](../../../../data-processing-lib/doc/python-launcher-options.md). | ||
| The following command line arguments are available | ||
| ``` | ||
| --docq_text_lang DOCQ_TEXT_LANG language used in the text content. By default, "en" is used. | ||
| --docq_doc_content_column DOCQ_DOC_CONTENT_COLUMN column name that contain document text. By default, "contents" is used. | ||
|
|
@@ -70,14 +88,37 @@ ls output | |
| ``` | ||
| To see results of the transform. | ||
|
|
||
| ### Code example | ||
|
|
||
| [notebook](../doc_quality.ipynb) | ||
|
|
||
| ### Transforming data using the transform image | ||
|
|
||
| To use the transform image to transform your data, please refer to the | ||
| [running images quickstart](../../../../doc/quick-start/run-transform-image.md), | ||
| substituting the name of this transform image and runtime as appropriate. | ||
|
|
||
| ## Testing | ||
|
|
||
| Following [the testing strategy of data-processing-lib](../../../../data-processing-lib/doc/transform-testing.md) | ||
|
|
||
| Currently we have: | ||
| - [Unit test](test/test_doc_quality_python.py) | ||
| - [Integration test](test/test_doc_quality.py) | ||
|
|
||
|
|
||
| ## Further Resource | ||
|
|
||
| - For those who want to learn C4 heuristic rules | ||
| - https://arxiv.org/pdf/1910.10683.pdf | ||
| - For those who want to learn Gopher statistics | ||
| - https://arxiv.org/pdf/2112.11446.pdf | ||
| - For those who want to see the source of badwords used by default | ||
| - https://github.com/LDNOOBW/List-of-Dirty-Naughty-Obscene-and-Otherwise-Bad-Words | ||
|
|
||
|
|
||
| ## Consideration | ||
|
|
||
| ## Troubleshooting guide | ||
| ### Troubleshooting guide | ||
|
|
||
| For M1 Mac user, if you see following error during make command, `error: command '/usr/bin/clang' failed with exit code 1`, you may better follow [this step](https://freeman.vc/notes/installing-fasttext-on-an-m1-mac) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shahrokhDaijavad @dtsuzuku-ibm This shows how to run the example script once we have cloned the repo. I wonder if we should also add a section to it that would explain how to use it in a notebook or a python script without cloning the repo but only with pip install . i.e.:
!pip install data-prep-toolkit
!pip install data-prep-toolkit-transform[doc_quality]
from doc_quality_transform python import ...
params = {
...
}
...
laucher.launch()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@touma-I
We can do all of these in jupyter/collab notebook which will be added in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dtsuzuku-ibm . that is great. Once you have the notebook, you can reference it. For now, I don't think this is complete until we have one or the other or both.