perf: use maxContentLength -1 instead of Infinity (#158)

The purpose of `Infinity` here is to have no limit, but as per axios/axios#2829 the check is enabled for all values > -1 and the check introduces a performance issue. Changing the value to `-1` prevents the check being enabled.
IBM · Aug 31, 2021 · adbbb3b · adbbb3b
1 parent 64fefb0
commit adbbb3b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/request-wrapper.ts b/lib/request-wrapper.ts
@@ -70,7 +70,7 @@ export class RequestWrapper {
     // to 'application/x-www-form-urlencoded'. This causes problems, so overriding the
     // defaults here
     const axiosConfig: AxiosRequestConfig = {
-      maxContentLength: Infinity,
+      maxContentLength: -1,
       maxBodyLength: Infinity,
       headers: {
         post: {

diff --git a/test/unit/request-wrapper.test.js b/test/unit/request-wrapper.test.js
@@ -70,7 +70,7 @@ describe('RequestWrapper constructor', () => {
     // the constructor puts together a config object and creates the
     // axios instance with it
     const createdAxiosConfig = axios.default.create.mock.calls[0][0];
-    expect(createdAxiosConfig.maxContentLength).toBe(Infinity);
+    expect(createdAxiosConfig.maxContentLength).toBe(-1);
     expect(createdAxiosConfig.maxBodyLength).toBe(Infinity);
     expect(createdAxiosConfig.headers).toBeDefined();
     expect(createdAxiosConfig.headers.post).toBeDefined();