remove broken discriminator rule in favor of new spectral rule #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rule verifies that the 'propertyName' value of the discriminator is present in each subschema.
This rule was buggy and not previously configurable. The same rule with identical (albeit fixed) behavior is now available in our Spectral ruleset under the name 'discriminator' and is configurable.
hudlow
reviewed
Feb 1, 2022
hudlow
reviewed
Feb 1, 2022
hudlow
reviewed
Feb 1, 2022
hudlow
reviewed
Feb 1, 2022
hudlow
reviewed
Feb 1, 2022
hudlow
reviewed
Feb 3, 2022
hudlow
reviewed
Feb 4, 2022
Comment on lines
+29
to
+31
| expect(visitedSchemas[0]).toBe( | ||
| 'paths./schema.get.responses.200.content.application/json.schema' | ||
| ); |
There was a problem hiding this comment.
Should we do this style instead?
expect(visitedSchemas).toContain(
'paths./schema.get.responses.200.content.application/json.schema'
);
There was a problem hiding this comment.
I intentionally chose not to use that style in order to make the test say "we found these schemas and only these schemas". In essence, to verify that there were no false positives in addition to no missing positives. I suppose my test still doesn't fully capture that though, because there is no check on the length of the array. I'll add that now
hudlow
approved these changes
Feb 4, 2022
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 4, 2022
# @ibm-cloud/openapi-ruleset [0.2.0](https://github.com/IBM/openapi-validator/compare/@ibm-cloud/[email protected]...@ibm-cloud/[email protected]) (2022-02-04) ### Features * add new spectral `discriminator` rule and remove old rule ([#367](#367)) ([390afc9](390afc9))
ibm-devx-sdk
pushed a commit
that referenced
this pull request
Feb 4, 2022
# [0.54.0](https://github.com/IBM/openapi-validator/compare/[email protected]@0.54.0) (2022-02-04) ### Features * add new spectral `discriminator` rule and remove old rule ([#367](#367)) ([390afc9](390afc9))
|
🎉 This PR is included in version 0.2.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.54.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rule was buggy and not previously configurable. The same rule with
identical (albeit fixed) behavior is now available in our Spectral ruleset
under the name 'discriminator' and is configurable.
I also did a lot of refactoring to reduce duplication and make it easier to add new
rules to our spectral ruleset.
Resolves #360