-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codeclimate #590
base: main
Are you sure you want to change the base?
Codeclimate #590
Conversation
|
@@ -140,18 +142,18 @@ The validator supports OpenAPI documents in either JSON or YAML format, using th | |||
.yaml | |||
.yml | |||
``` | |||
Assuming your command shell supports the use of wildcards, you can use wildcards when specifying the names of files to be validated. | |||
If the string ends with '/', it will be searched recursively for supported files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this necessary for the code climate support?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not at all, but a config.json
passed by codeclimate file looks like this:
{
"enabled":true,
"channel":"stable",
"include_paths": [
".gitignore",
"public/",
".gitattributes",
"LICENSE",
".gitlab-ci.yml",
"Dockerfile",
"docker-entrypoint.d/",
".codeclimate.yml"
],
"debug":"1"
}
when executing in biletado/apidocs.
One can still add a files
section in .codeclimate.yml
like I do at the moment for testing until the implementation for the recursive filesearch is implemented. This is then added to the config.json
. You can have a look at the .codeclimate.yml
I used in the mentioned project for testing this as an engine.
fa9e7b6
to
0333872
Compare
Signed-off-by: Matthias Blümel <[email protected]>
Signed-off-by: Matthias Blümel <[email protected]>
Signed-off-by: Matthias Blümel <[email protected]>
94b4d37
to
0a238fb
Compare
See: https://docs.gitlab.com/ee/ci/testing/code_quality.html#required-images Signed-off-by: Matthias Blümel <[email protected]>
gitlab integration looks nice :) |
PR summary
This PR adds the compatibility to run as CodeClimate Engine.
Closes: #512
Todo
(but they are not shown in the "Changes" like they should because the project has an OSS ultimate license :/)needs a run on the target branchinclude_paths
FROM jamescooke/openapi-validator:$version
WORKDIR /code
ENTRYPOINT ["lint-openapi", "--config", "/config.json", "--codeclimate"]
Containerfile
PR Checklist
General checklist
Please make sure that your PR fulfills the following requirements: