Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding documentation link at readme. #154

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Adding documentation link at readme. #154

merged 1 commit into from
Jan 21, 2025

Conversation

yuki462-b
Copy link
Contributor

@yuki462-b yuki462-b commented Jan 17, 2025

Related Issue

No related issue

Related PRs

#147

What this PR does / why we need it

As far as I have searched, there is no link to the documentation https://ibm.github.io/oper8/ at README or github repository's About section. The link will not change, so I just hardcoded to README file.

If applicable**

  • this PR contains documentation
  • this PR contains unit tests
  • this PR has been tested for backwards compatibility

What gif most accurately describes how I feel towards this PR?

where

Copy link
Collaborator

@HonakerM HonakerM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for adding the link.... I still haven't forgotten about adding an example. It's somewhere on my TODO list 😅

@yuki462-b
Copy link
Contributor Author

@gabe-l-hart
Please review this PR when you can 🙏. I don't have permission to merge.

@HonakerM HonakerM merged commit 001f7a8 into IBM:main Jan 21, 2025
6 checks passed
@HonakerM
Copy link
Collaborator

@yuki462-b I forgot I have merge powers😅.

@gabe-l-hart
Copy link
Collaborator

@HonakerM Yes! Sorry it took me a while, but in general if you approve, go ahead and merge it unless you think there's something specific you want me to look at.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants