Kind specific VCS checkout #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Honaker <[email protected]>
gabe-l-hart
approved these changes
Jan 29, 2025
|
This shouldn't cause any problems because it is already running in the subprocess. It'd act like the user had set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Supports #?
Related PRs
This is a followup PR to #155
What this PR does / why we need it
After testing my previous PR I was able to get around the strict versioning error but then ran into one regarding VCS. There is probably a more elegant solution but I just duplicated my existing solution
Special notes for your reviewer
@gabe-l-hart LMK if you'd like me to spend some more time coming up with a better generic solution (maybe
unversioned_kind_regex: <>?If applicable**
What gif most accurately describes how I feel towards this PR?
(this gif is accurate to my feelings on this PR)