Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add action to build objects in project explorer and source orbit #634

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SanjulaGanepola
Copy link
Collaborator

Changes

  • Add new buildObjectCommand field in iproj.json to set command to build a specific object in the project
  • Add new Set Build Object Command action
  • Add new Run Build Object action
    • Added to objects in libraries under Library List and Object Libraries
    • Added to objects under Source Orbit heading in Project Explorer
    • Added to objects in Source Impacts and Change Impacts views provided by Source Orbit
  • Updated documentation with new feature

Copy link

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Member

@edmundreinhardt edmundreinhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THis is fantastic, would have been great to have in the demo with Research.
Great work. I am requesting a minor tweak


![Set Build Object Command](../../assets/ProjectExplorer_41.png ':size=500')

To then build a target object, locate the object under the **Library List** or **Object Libraries** and use the right-click **Run Build Object** action.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the menu item would be better as 'Build Object', this is different than 'Run Build' which implies running the full build. I know this means redoing some screen caps, but I believe it would be an improvement

>
> This action can also be performed on objects under the [Source Orbit heading](https://ibm.github.io/sourceorbit/#/./pages/extension/index?id=ibm-i-project-explorer-integration) in **Project Explorer** as well as on objects in both [impacted object views](https://ibm.github.io/sourceorbit/#/./pages/extension/index?id=view-impacted-objects) provided by Source Orbit (**Source Impacts** and **Change Impacts**).

![Run Build Object](../../assets/ProjectExplorer_42.png ':size=500')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer Build Object

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add action to be build objects for children under Source Orbit heading
2 participants