-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enabled commandline with number of indices as argument #326
base: develop
Are you sure you want to change the base?
Conversation
👍
The default is optimization, you can specify that explicitly or not. It was meant to be extendable to future tasks that might be added. No strong opinion. Command line interface could take some improvements anyways. If you change it this way, this also needs to be updated in some tests and examples. You seem to have overwritten a couple of my previous changes. Please check the diff and revert the probably unintended changes. |
What's the status here? Can be merged? One more round of review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me... At a second glance: not sure whether things also work if no parameter indices are passed... But this should fix the current problem for the moment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test case similar to
def test_nompi_gradient_check(): |
SonarCloud Quality Gate failed. |
bbf24f8
to
e4fb08a
Compare
So i think this should work as a first draft, i would need to enable parsing comma separated ids or indices as well, which i will try to finish this week. Also i noticed that the option
-t
should basically only be used when we want to perform a gradient check? I would suggest removing-t
and going for-g
for the gradient check. But could also be that i missed something.