Added Gradient Button On Colour tab In Plot Options Sub Dialog. #8733

MeSophie · 2024-01-16T07:15:12Z

Fixes #8623.
@rdstern @lilyclements I added the gradient button on color tap. Please have a look.

update

rdstern · 2024-01-30T07:51:20Z

@lilyclements could you check and approve. You are better at colours than me!

rdstern

@MeSophie that's a nice addition and it seems to work too!

a) The sub-dialog has become excessively wide, see above.
b) The range of colours for the gradient is very small. Usually it is linger and with an option to choose one:

c) The setting of discrete at the top right always resets. I made it continuous when it was needed, and it didn't remember. The next time I returned there it has reset to discrete..

Here is a nice looking heatmap, making use of the gradient and going from Yellow to Blue!

update

MeSophie · 2024-02-05T11:00:07Z

@rdstern Could you please test the change? For c) the control always resets the old value because it automatically detects the value of the receiver y. For cases such as histogramm and bar plots, the control value remains discrete because it is the default value and there is no y variable.

rdstern

@MeSophie the width of the dialog is now resolved.
a) The high option now has the bigger set of colours. But could you please add the pick colour option too?
b) The low is still short. Is that intentional? Could that become the same as the High option?
c) In the dialog I changed and used Pastel1 as the palette. If I then change discrete to continuous or vice versa, it resets the palette to the default of Accent. And it is reset to the default of Accent, each time I return to the tab. That also happens with other options, e.g. divergent, that use that control.

d) In the heatmap dialog the setting of the colours (discrete or continuous) depends on the fillcontrol in the dialog:

Usually, as here, it is numeric, so continuous. But it can be a factor, in which case discrete is needed. Can this be detected, and become automatic on the colour tab? If it has to be a single setting for the dialog, then usually it will be numeric, and so continuous.

MeSophie · 2024-02-07T11:26:55Z

@rdstern I solved part a), b) and c). For part d) I'm still investigating on it.

update

rdstern

@MeSophie I'm getting build errors?

MeSophie · 2024-02-16T07:07:04Z

@MeSophie I'm getting build errors?

@rdstern I'm still working on it. I'll let you know when I'm done.

MeSophie · 2024-02-16T09:11:55Z

@rdstern Could you please check the dialog ?

rdstern · 2024-02-16T22:06:11Z

@MeSophie this still seems to bed giving you various troubles. I tried with the usual survey, bar chart, village by variety and then your colour an gradient.
Here is the sub-dialog and correctly remembering what I tried before:

When I run it gives an error and I can see why. Here is the code generated:

# Dialog: Bar Chart

survey <- data_book$get_data_frame(data_name="survey")
last_graph <- ggplot2::ggplot(survey, mapping=ggplot2::aes(x=village, fill=variety)) + ggplot2::geom_bar(stat="count") + scale_fill_gradient() + theme_grey()
data_book$add_object(data_name="survey", object_name="last_graph", object_type_label="graph", object_format="image", object=check_graph(graph_object=last_graph))
data_book$get_object_data(data_name="survey", object_name="last_graph", as_file=TRUE)
rm(list=c("last_graph", "survey"))

It has ignored all the options in scale_fill_gradient(). And just given it like this!

@N-thony there is also a more general oddity, which seems far worse here than before. The first time you click on the Plot Options it takes ages to go into them. In general at least 5 seconds, but perhaps more obviously here, it took over 25 seconds. Could you investigate, either in this pull request, or more generally in a new pull request? Where is it going in the code the first time that takes so long - and also isn't needed after that?

MeSophie · 2024-02-19T19:29:11Z

@rdstern the message error was because I didn't put the appropriate function for discrete scale. I added scale_fill_manual and scale_colour_manual function. Could you please test the dialog again?

MeSophie · 2024-02-20T08:48:10Z

@rdstern by testing the new change in Boxplot dialog with our survey data, As shown in the figure below, detection in the colour tap of our plot options sub dialog executes perfectly as a function of the variable Y. When we click Return and then Ok, we get an error message saying discrete value supplied to continue scale. This is because the fill value is discrete and the scale fill function used is continuous. Would it be a good idea to carry out the detection here according to the fill parameter, as we did in the HeatMap Dialog?

MeSophie · 2024-02-26T09:09:27Z

@rdstern please anything new about this PR?

rdstern · 2024-02-27T17:37:14Z

@MeSophie yes I have just read your question above again. You are right. In this dialog it is the fill that is being coloured, not the y variable. So it should detect when that is a factor and then use discrete.

MeSophie · 2024-02-28T09:39:14Z

@rdstern Could you please check the new change?

@MeSophie yes I have just read your question above again. You are right. In this dialog it is the fill that is being coloured, not the y variable. So it should detect when that is a factor and then use discrete.

@rdstern Could you please check the new change?

rdstern

@MeSophie great. @N-thony this is quite a big change. When you are happy it will be good to mergs.

N-thony · 2024-02-28T12:47:27Z

instat/dlgBoxPlot.vb

@@ -56,6 +56,7 @@ Public Class dlgBoxplot
    Private clsXScaleDateFunction As New RFunction
    Private clsYScaleDateFunction As New RFunction
    Private clsFacetsFunction As New RFunction
+    Private Fillvariable As Boolean = True


can you rename this variable for something more descriptive of it purpose?

This is solved.

N-thony · 2024-02-28T12:47:48Z

instat/dlgHeatMapPlot.vb

@@ -19,6 +19,7 @@ Public Class dlgHeatMapPlot
    Private bFirstLoad As Boolean = True
    Private bRCodeSet As Boolean = True
    Private bReset As Boolean = True
+    Private Fillvariable As Boolean = True


I don't think you need this

This is solved.

N-thony · 2024-02-28T12:48:12Z

instat/dlgHeatMapPlot.vb

@@ -554,7 +555,7 @@ Public Class dlgHeatMapPlot
             clsNewScaleFillViridisFunction:=clsScaleFillViridisFunction, clsNewScaleColourViridisFunction:=clsScaleColourViridisFunction, clsNewYLabTitleFunction:=clsYlabFunction, clsNewLabsFunction:=clsLabsFunction,
             clsNewFacetFunction:=clsRFacetFunction, clsNewThemeFunction:=clsThemeFunction, dctNewThemeFunctions:=dctThemeFunctions, ucrNewBaseSelector:=ucrHeatMapSelector, clsNewFacetVariablesOperator:=clsFacetVariablesOperator,
             strMainDialogGeomParameterNames:=strGeomParameterNames, clsNewCoordPolarFunction:=clsCoordPolarFunction, clsNewCoordPolarStartOperator:=clsCoordPolarStartOperator,
-             clsNewAnnotateFunction:=clsAnnotateFunction, clsNewXScaleDateFunction:=clsXScaleDateFunction, clsNewYScaleDateFunction:=clsYScaleDateFunction, bReset:=bResetSubdialog)
+             clsNewAnnotateFunction:=clsAnnotateFunction, clsNewXScaleDateFunction:=clsXScaleDateFunction, clsNewYScaleDateFunction:=clsYScaleDateFunction, NewFillvariable:=True, bReset:=bResetSubdialog)


Same with NewFillvariable

This is solved.

N-thony · 2024-02-28T12:51:55Z

instat/sdgPlots.vb

@@ -108,6 +110,7 @@ Public Class sdgPlots
    Private dctDivergingPairsContinuous As New Dictionary(Of String, String)
    Private dctQualititivePairsContinuous As New Dictionary(Of String, String)
    Public strAxisType As String
+    Public Fillvariable As Boolean = False


Do you need this?

@N-thony I thing this question is for Boxplot dialog. If so this is solved.

N-thony · 2024-02-28T13:50:32Z

instat/sdgPlots.vb

@@ -108,6 +110,7 @@ Public Class sdgPlots
    Private dctDivergingPairsContinuous As New Dictionary(Of String, String)
    Private dctQualititivePairsContinuous As New Dictionary(Of String, String)
    Public strAxisType As String
+    Public FillAesdetection As Boolean = False


for Boolean type we always name a variable by starting with small b see line 72.
But my question is to understand if you need it?

This is Solve and I added the b on FillAesdetection and NewFillAesdetection

I don't think you need line 113

I don't think you need line 113

@N-thony I deleted this line

N-thony · 2024-02-28T14:04:56Z

instat/sdgPlots.vb

    End Sub

    Public Sub SetRCode(clsNewOperator As ROperator, clsNewCoordPolarFunction As RFunction, clsNewCoordPolarStartOperator As ROperator, clsNewYScalecontinuousFunction As RFunction, clsNewXScalecontinuousFunction As RFunction, clsNewLabsFunction As RFunction,
                        clsNewXLabsTitleFunction As RFunction, clsNewYLabTitleFunction As RFunction, clsNewFacetFunction As RFunction, clsNewThemeFunction As RFunction, dctNewThemeFunctions As Dictionary(Of String, RFunction), ucrNewBaseSelector As ucrSelector,
                        bReset As Boolean, Optional clsNewGlobalAesFunction As RFunction = Nothing, Optional clsNewXScaleDateFunction As RFunction = Nothing, Optional clsNewYScaleDateFunction As RFunction = Nothing, Optional clsNewFacetVariablesOperator As ROperator = Nothing,
                        Optional clsNewScaleFillViridisFunction As RFunction = Nothing, Optional clsNewScaleColourViridisFunction As RFunction = Nothing, Optional strMainDialogGeomParameterNames() As String = Nothing, Optional clsNewAnnotateFunction As RFunction = Nothing,
-                        Optional bNewEnableFill As Boolean = True, Optional bNewChangeScales As Boolean = False, Optional bNewEnableColour As Boolean = True, Optional bNewEnableDiscrete As Boolean = True, Optional strNewAxisType As String = "discrete")
+                        Optional bNewEnableFill As Boolean = True, Optional NewFillAesdetection As Boolean = False, Optional bNewChangeScales As Boolean = False, Optional bNewEnableColour As Boolean = True, Optional bNewEnableDiscrete As Boolean = True, Optional strNewAxisType As String = "discrete")


bChangeAesParameter instead of NewFillAesdetection?

This is solved

rdstern

@MeSophie I again tried for a nice gradient with this:

It is working nicely for me! @N-thony I am happy the code is becoming more solid, and am approving again.

MeSophie and others added 4 commits January 12, 2024 10:49

Merge pull request #164 from africanmathsinitiative/master

35fabb1

update

Merge pull request #165 from africanmathsinitiative/master

6b5ae26

update

Merge pull request #166 from africanmathsinitiative/master

2631df5

update

Added Gradient button on colour tap

c37482c

rdstern changed the title ~~Added Gradient Button On Colour tap In Plot Options Sub Dialog.~~ Added Gradient Button On Colour tab In Plot Options Sub Dialog. Jan 16, 2024

rdstern requested changes Feb 2, 2024

View reviewed changes

MeSophie and others added 2 commits February 5, 2024 11:39

Minor change made

846dba2

Merge pull request #182 from IDEMSInternational/master

4a60413

update

rdstern requested changes Feb 5, 2024

View reviewed changes

minor change

7e24db7

rdstern mentioned this pull request Feb 13, 2024

Improved Heatmap Dialog in the Describe > Graphics #8802

Merged

MeSophie and others added 2 commits February 14, 2024 14:13

Merge pull request #189 from IDEMSInternational/master

f021c70

update

minor change

9db55b7

MeSophie marked this pull request as draft February 15, 2024 08:39

Minor change

98562e7

rdstern reviewed Feb 15, 2024

View reviewed changes

Minor change

c1aca24

MeSophie marked this pull request as ready for review February 16, 2024 09:10

MeSophie added 2 commits February 19, 2024 19:34

added scale fill and color manual functions

457c4dc

minor change

60b0254

minor change in boxplot dialogue

fec9d5b

rdstern previously approved these changes Feb 28, 2024

View reviewed changes

N-thony requested changes Feb 28, 2024

View reviewed changes

Minor change

e054a4d

MeSophie dismissed rdstern’s stale review via e054a4d February 28, 2024 13:41

N-thony requested changes Feb 28, 2024

View reviewed changes

MeSophie added 2 commits February 28, 2024 15:21

minor change

1fbf9d5

minor change

36ae363

rdstern approved these changes Feb 28, 2024

View reviewed changes

N-thony approved these changes Feb 29, 2024

View reviewed changes

N-thony merged commit fbe6939 into IDEMSInternational:master Feb 29, 2024
2 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Gradient Button On Colour tab In Plot Options Sub Dialog. #8733

Added Gradient Button On Colour tab In Plot Options Sub Dialog. #8733

MeSophie commented Jan 16, 2024

rdstern commented Jan 30, 2024

rdstern left a comment •

edited

Loading

MeSophie commented Feb 5, 2024

rdstern left a comment

MeSophie commented Feb 7, 2024

rdstern left a comment

MeSophie commented Feb 16, 2024

MeSophie commented Feb 16, 2024

rdstern commented Feb 16, 2024

MeSophie commented Feb 19, 2024

MeSophie commented Feb 20, 2024 •

edited

Loading

MeSophie commented Feb 26, 2024

rdstern commented Feb 27, 2024

MeSophie commented Feb 28, 2024

rdstern left a comment

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

N-thony Feb 28, 2024

MeSophie Feb 28, 2024

rdstern left a comment

Added Gradient Button On Colour tab In Plot Options Sub Dialog. #8733

Added Gradient Button On Colour tab In Plot Options Sub Dialog. #8733

Conversation

MeSophie commented Jan 16, 2024

rdstern commented Jan 30, 2024

rdstern left a comment • edited Loading

Choose a reason for hiding this comment

MeSophie commented Feb 5, 2024

rdstern left a comment

Choose a reason for hiding this comment

MeSophie commented Feb 7, 2024

rdstern left a comment

Choose a reason for hiding this comment

MeSophie commented Feb 16, 2024

MeSophie commented Feb 16, 2024

rdstern commented Feb 16, 2024

MeSophie commented Feb 19, 2024

MeSophie commented Feb 20, 2024 • edited Loading

MeSophie commented Feb 26, 2024

rdstern commented Feb 27, 2024

MeSophie commented Feb 28, 2024

rdstern left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rdstern left a comment

Choose a reason for hiding this comment

rdstern left a comment •

edited

Loading

MeSophie commented Feb 20, 2024 •

edited

Loading