Issue when checking all packages installed #9234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ChrisMarsh82 @rdstern I realized after a discussion on Skype with @Patowhiz that
AllPackagesInstalled()is called immediately after starting the R engine but before executing setup scripts viaExecuteSetupRScriptsAndSetupRLinkAndDatabook(). This ordering causes issues becauseAllPackagesInstalled()depends on R scripts or functions loaded later in the process.To resolve this, I rearrange the order so that
ExecuteSetupRScriptsAndSetupRLinkAndDatabook()is executed immediately after starting the R engine, allowing it to configure the necessary R environment before checking for installed packages. Have a look.Note that this is only for developers to be in track also of installed packages in the development. It is not a big issue because it doesn't affect users. We can leave it open and use it if needed.