Removing Scalars from non-Scalar Calculations

[derekagorhom]

Fixes #9376
This PR should prevent the issue of the scalars function appearing when the user is not using the scalar option.
@rdstern , @N-thony can you review this code
Thanks

[rdstern]

@derekagorhom it is only partly working well.
Please can you get a scalar and the try to use it. I used the survey and saved mean(yield) into mean_yield as a scalar. Then tried a calculation of yield * mean_yield.
It says it doesn't recognise mean_yield. It used to do that fine.

[derekagorhom]

@rdstern I have made the fix which prevented the check scalar options from producing results
Can you have a look at it again
Thanks

[rdstern]

@derekagorhom you have solved that problem, but seem to have created some more. You may need help, because it looks to be rather a mess now:
And I also wonder what testing you did, before my tests?

Here is what I did:
a) With the survey data I tried yield * 2 . That was to check there was no longer a use of the scalar lines in the output window, That seems fine.
b) Next I used, Clear, then the summary keyboard, got mean(yield) and saved it as a scalar called mean_yield. That seems almost fine, except I got a bonus of the result also in the output window. I am not sure whether that was happening before?
c) Then I used Clear, and got yield * mean_yield (pressed the scalar button for that), and saved it into a column, namely calc1. I worked but also gave the mess.
d) I now see it has also saved a copy of calc1 (a vector) as though it is another scalar. So now I have the columns I want, plus this bonus that I really, really don't want.

[rdstern]

@derekagorhom that's a relief. It now seems to be working. Many thanks.
@N-thony can you test as well as check the code. As a presumably separate issue I note that the number of significan figures does not apply to the scalars. They are displayed here with 13 decimals in the data frame metadata. Is this easy to change?