-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some Change Made in Start of Rain Dialog. #9387
Conversation
@MeSophie I have been trying the start in your pull request on the end of the rains/season. It now seems to be working ok? |
@rdstern We can't close this PR. This is where I fixed the 312 years problem and also, as you can see from the issue, the code to get the start status has been improved. Perhaps you tried the start of the rain when you already had the end of the rain or the end of the season, which is why you got 312 years. |
@MeSophie thank you for the update. I usually did a seasonal rainfall total before the start of the rains, so the 312 seasons may be from there. |
@rdstern These changes are ready to be test. Please have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #9380
This PR is not yet ready to review because it need some function of PR #9214. So I convert it to draft.