Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Change Made in Start of Rain Dialog. #9387

Merged
merged 5 commits into from
Jan 31, 2025

Conversation

MeSophie
Copy link
Contributor

Fixes #9380
This PR is not yet ready to review because it need some function of PR #9214. So I convert it to draft.

@MeSophie MeSophie marked this pull request as draft January 23, 2025 11:36
@rdstern
Copy link
Collaborator

rdstern commented Jan 24, 2025

@MeSophie I have been trying the start in your pull request on the end of the rains/season. It now seems to be working ok?
I wonder what you are adding here, or can this be closed?

@MeSophie
Copy link
Contributor Author

@MeSophie I have been trying the start in your pull request on the end of the rains/season. It now seems to be working ok? I wonder what you are adding here, or can this be closed?

@rdstern We can't close this PR. This is where I fixed the 312 years problem and also, as you can see from the issue, the code to get the start status has been improved. Perhaps you tried the start of the rain when you already had the end of the rain or the end of the season, which is why you got 312 years.

@rdstern
Copy link
Collaborator

rdstern commented Jan 27, 2025

@MeSophie thank you for the update. I usually did a seasonal rainfall total before the start of the rains, so the 312 seasons may be from there.

@MeSophie MeSophie marked this pull request as ready for review January 31, 2025 12:42
@MeSophie
Copy link
Contributor Author

@rdstern These changes are ready to be test. Please have a look.

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MeSophie that's great - all seems to work.
@N-thony please can you check and merge. I think this was a relatively small change.

@N-thony N-thony merged commit 9945129 into IDEMSInternational:master Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fixes for start rains dialog
3 participants