Some Change Made on Length Of Season Dialog #9394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts-patch-1 Update calculations.R
Allowing checks and conversions if join type differs between two data frames
… the same class as that of the from data frame
Adding function in linking to convert variables in a to data frame to be the same class as that of the from data frame
rdstern
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
@MeSophie that's good and I am approving.
@N-thony could you check and merge if ok?
Meantime @MeSophie can you make a new issue, for later to replace the up_down control with our usual Day Range control, but call the button Day Number here. Then there is the usual sub-dialog, (maybe) where you disable everything except the To with Fixed Day. The receiver on the main dialog can perhaps be less narrow, because it is only giving the number.
N-thony
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9391
@rdstern @N-thony I have added the length_more variable (In accordance with the discussion in PR #9157 ) and corrected some labels on the Length Of Season Dialog. Please have a look.