Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

content: 1.2.58 #114

Merged
merged 2 commits into from
Nov 13, 2024
Merged

content: 1.2.58 #114

merged 2 commits into from
Nov 13, 2024

Conversation

esmeetewinkel
Copy link
Collaborator

No description provided.

@@ -140,7 +140,6 @@ Assets that appear in app-data but do not have references within sheets
| ios/icon.png | 128.1 |
| ios/splash.png | 147.4 |
| map_data/forecast_data.json | 50.2 |
Copy link
Collaborator Author

@esmeetewinkel esmeetewinkel Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jfmcquade Can I remove the unused asset map_data/forecast_data.json (in here)? I double checked the sheet comp_map_layer_data and it doesn't seem to be used

Copy link
Collaborator

@jfmcquade jfmcquade Nov 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it can be removed. Thanks for checking, I'll try to avoid permanently adding any more large data files for the map component

@esmeetewinkel esmeetewinkel merged commit 0ee0526 into main Nov 13, 2024
4 checks passed
@esmeetewinkel esmeetewinkel deleted the content/1.2.58 branch November 13, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants