content: 1.2.19

[esmeetewinkel]

Update config following merge of IDEMSInternational/open-app-builder#2269 to remove now redundant line.

[esmeetewinkel]

@jfmcquade could it be that the deployment preview action is failing because of this removed config line?

(I've used the action succesfully just now on PRs from plh_facilitator_mx on the code version v0.16.28, which is basically master at the moment, which is what this content branch using)

[github-actions]

Visit the preview URL for this PR (updated for commit 3a5c30b):

https://idems-debug--pr61-content-1-2-19-urppqfn9.web.app

_{(expires Mon, 22 Apr 2024 15:04:07 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: f2bfd21fc73bf25db0e74968614b72bee30e3476}

[jfmcquade]

The action is indeed failing because of the removed config line, but I'm not sure why.

I did try running the action with this repo pointing to the v0.16.28 code version just in case, which failed in the same way.

There doesn't seem to be anything relevant in the actions cache, but I tried deleting the artefacts and that didn't resolve the issue.

So I reverted the deletion of the line that sets config.app_data.output_path = "./app_data" in the config (this commit), and it built successfully. So for some reason the default value for output_path, as it now exists on master, isn't being used correctly, but I'm not sure why yet.

[jfmcquade]

I wondered if it may be related to this repo not having a DEPLOYMENT_PRIVATE_KEY secret to decrypt the encrypted config files, somehow causing the deployment config to not be compiled correctly, but I've added one and the action is still failing in the same way.

Although I did notice a related potential issue: as part of the deployment set workflow, decrypt runs after the deployment is compiled. This means that when setting a deployment for the first time, the decrypted files are not found and, presumably, the values are not included in the compiled config.

@chrismclarke do you think this is a genuine issue following the firebase config PR, or am I misunderstanding? A fix might be to add a step to reusable-app-build to decrypt the config encrypted folder directly after running Populate Encryption key.

[jfmcquade]

OK, I found the issue: in IDEMSInternational/open-app-builder#2269 I set the default to "./app-data", where it should be "./app_data" 🤦

In trying to fix it, I accidentally pushed directly to master, see this commit. There shouldn't be any knock-ons from this change (which is actually a fix), as all other deployment configs still explicitly set the value themselves. But I didn't think pushing to master was possible, shouldn't our branch protection rules prevent that, @ChrisMarsh82 ?

[ChrisMarsh82]

@jfmcquade we do have this set up on parenting-app-ui

However, you can bypass this as an administrator.

We can set this up so it can't be bypassed by admin but it would mean you will always need a review. This could cause issues with quick fixes.

[jfmcquade]

However, you can bypass this as an administrator.

We can set this up so it can't be bypassed by admin but it would mean you will always need a review. This could cause issues with quick fixes.

Thanks, that makes sense. I wasn't aware that admins could bypass the branch protection rules. On balance I'd probably rather I didn't have the power to do so directly from the CLI with git push, but it's true that it may sometimes be required for quick fixes. Good to be aware of, I'll be more careful from now on

[chrismclarke]

@ChrisMarsh82 @jfmcquade
I'd say the safest option is probably to disable administrator bypass. If urgent fixes are required admins can still untoggle the option in repo settings so more like a 2-step bypass which is probably worth it given the potential to accidentally push commits directly to master (I've definitely made that mistake in the past myself)

[esmeetewinkel]

I'd say the safest option is probably to disable administrator bypass.

It seems someone disabled administrator bypass