-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create universal parser #143
Open
istride
wants to merge
33
commits into
main
Choose a base branch
from
uni-parser
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in ODS import has been fixed but not yet released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a "universal" parser that is intended to convert between spreadsheets and JSON and be useful as a basis for any application-specific purpose (e.g. ParentText/ChatbotBuilder, AppBuilder).
A concerted effort has been made to preserve the existing conversion behaviour of the current ParentText-specific parser, for backwards-compatibility. A major exception has been made for templates, which are no longer interpreted during the conversion, just copied verbatim. An overview of the conversion behaviour can be found in
docs/notation.md
.The universal parser does not use Pydantic models during conversion. Instead, the parser opportunistically converts strings to the JSON types. For example, if a string can be converted to a number it will be; if not the parser will fall back to different conversion methods until one works, or none of them work and the string is just passed through. A method for directing the conversion process is considered out of scope.
Metadata is stored within the JSON, in a top-level property with key
_idems
, to direct the conversion back to sheets. Currently, only the original table headers are stored as metadata, to preserve their order and layout.Two CLI sub-commands have been added:
sheets-to-uni
: converts a spreadsheet to nested ("universal") JSONuni-to-sheets
: reverse operation back to spreadsheet; currently limited to ODS outputExamples:
Supporting other output formats is considered out of scope for this PR.