-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plate conversion #1
Conversation
@sbesson : do you know if this is (more or less) ready to go in? Just thinking about the needed bumps for bioformats2raw 0.3.0 (see https://forum.image.sc/t/issue-with-opening-zarr-inside-napari/56089/15). Perhaps this needs adding to ome_zarr_test_suite as well. |
I have tested it to generate sample data so I am confident the conversion works as a proof-of-concept (and potentially a candidate for There is a fundamental limitation we should discuss before moving forward and using this in production. Like for the non-HCS image use case, the rendering settings need to be exported as JSON first and injected via command-line option. The current state of this PR uses a single JSON file for all the images. While this will do an fair job for some plates, this effectively assumes all images have the same rendering settings, which is not always true, and the same name which is definitely not true. I can think of two routes, both of them require more discussion and design:
|
Looking at how the logic is implemented in |
Discussed today: @sbesson giving it a try and then we can adjust, refactor, and roll out. |
ome/omero-cli-zarr#76 would be a first step towards migrating the |
From my side, Opened ome/omero-cli-zarr#85 to handle the HCS use case. My vote would be to close this draft PR and keep pushing as much as the generic export as possible to the OMERO plugin. |
Is a change here needed to consume ome/omero-cli-zarr#85? |
Quite likely. While this repository is using submodules + Docker, I have been primarily using Conda with an I could look into updating this repository accordingly so that any new conversion would benefit from the latest releases of the tools? |
Ongoing set of improvements allowing to use these tools to convert plates
merge.py
to consume a top-level rendering file and apply it recursively to all subfolders of a Zarr plate