-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace jekyll site with zarr_samples.csv #20
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the set of coupled PRs, I understand the URLs that should compared are https://deploy-preview-2--deft-vacherin-6c652f.netlify.app/?csv=https://raw.githubusercontent.com/will-moore/ome-ngff-samples/replace_page_with_csv/zarr_samples.csv&columns=Version,Axes,shape,chunks,Wells,Fields,Keywords,Thumbnail vs https://idr.github.io/ome-ngff-samples/.
Based on the above, a few immediate comments:
- the URL shortening looks stangre
- the icon of the validator is now the mainline OME icon. Is that expected?
- the ability to sort columns and to control the pagination are lost, so is the search box
- the column order is different. Although there was no strict order, in terms of usability, the thumbnail is buried at the far right of my browser window and the DOI column which is mostly blank is right at the center
- some of the keywords e.g. labels seem to be lost, are these meant to be turned into separate columns?
- the link to the source IDR data in the
Study
column is lost
There might be some discussion on each of these point to assess whether they are blockers or not. I have not been part of the discussion behind the migration to the new catalog framework so I cannot comment on the expectations. The review above assumes the target catalog should be a like-for-like replacement but some of the changes might be on purpose and up for evaluations.
In terms of review process, I assume adding new entries could be tested more simply by opening a PR against this repository and providing a URL to the catalog endpoint using the staging CSV as the input? If so, that's definitely an improvement compared to the current workflow and something we'll want to add e.g. to the README.
@sbesson - thanks for the review - yes, a few features aren't quite ready yet, so I think this PR can wait until we feel that the new page is good enough to replace the old.
|
3c80f8f
to
a52e184
Compare
@sbesson Instead of getting rid of the jekyll site and add a redirect, I decided instead to use an iframe to bring the ome-zarr-catalog table onto the main page. |
In general, using samples as a testing ground makes sense since the new JS-based infra should minimally do everything we need. Since the testing is tricky, though, it might make sense that we set up a temporary jekyll-based repo that you can push to for comparison. |
If I configure my fork of this repo correctly, can I get it to deploy a chosen branch at https://will-moore.github.io/ome-ngff-samples/ to use for testing? |
OK, this branch is now deployed at https://will-moore.github.io/ome-ngff-samples/ |
Thanks, @will-moore. First thing I noticed is that the user doesn't necessarily have any idea that things are being loaded in the background. Also, it's expected that the thumbnails don't zoom when embedded as an iframe? |
The thumbnails don't zoom as I'm not using viv and Deck.gl any more. I'm just loading pixels for lowest resolution with zarr.js and manually rendering to canvas. I got Deck.gl errors when there where more than 16 instances on the page. |
👍 |
@josh - Added |
👍 |
Updated to use https://ome.github.io/ome-zarr-catalog - and updated PR description. |
@joshmoore do we still want to pursue this change to the |
I definitely still like the idea. What's held me back has been the lack of parity in the look&feel. Do you have the feeling that we are getting closer? (Can't do a great review from this device) |
With the app at https://ome.github.io/ome-zarr-catalog we can largely replace the Jekyll site.
This repo can still be used for simply listing the IDR ngff samples. This PR replaces the whole repo with a single csv file,
containing only the data that isn't loaded dynamically from the Zarr image, and a home page that hosts the catalog in an iframe.
To test, see page at https://will-moore.github.io/ome-ngff-samples/