Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VS_ConstPower = 1 #67

Merged
merged 1 commit into from
Mar 7, 2024
Merged

VS_ConstPower = 1 #67

merged 1 commit into from
Mar 7, 2024

Conversation

ptrbortolotti
Copy link
Contributor

Switch ROSCO logic from constant torque to constant power

comparison

@ptrbortolotti ptrbortolotti requested a review from dzalkind March 3, 2024 14:22
@ptrbortolotti
Copy link
Contributor Author

@fzahle is this what the DTU controller does? @dzalkind what's more realistic?

@fzahle
Copy link
Collaborator

fzahle commented Mar 6, 2024

@tkbadtu you are better suited for answering the above question, thanks!

@tkbadtu
Copy link
Collaborator

tkbadtu commented Mar 6, 2024

DTU-WEC uses a blend of constant torque and constant power, in this model it's 0.9 (mostly constant power).

dzalkind
dzalkind approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@dzalkind dzalkind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These results look as expected. ROSCO doesn't (yet) blend constant torque/power, but that's good to know!

@ptrbortolotti ptrbortolotti merged commit ba5d6c4 into main Mar 7, 2024
2 checks passed
@ptrbortolotti ptrbortolotti deleted the VS_ConstPower branch March 7, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzalkind dzalkind dzalkind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptrbortolotti @fzahle @tkbadtu @dzalkind