Update docker image to use mamba based image + use conda packages as … #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leavauchier
force-pushed
the
fix-docker-image
branch
from
2c7d9d5
to
bf398a3
Compare
CharlesGaydon
requested changes
Jan 15, 2024
There was a problem hiding this comment.
@leavauchier Nice that if finally build. However the install does not look like it would work with cuda in its current state. Could you update and test? :)
leavauchier
force-pushed
the
fix-docker-image
branch
from
bf398a3
to
4f092c3
Compare
I updated and tested on my local machine, but if we want to have automatic testing, it would require that the ci machine has cuda installed too |
Then I'll merge as soon as the CI works :) |
leavauchier
force-pushed
the
fix-docker-image
branch
from
d98e0af
to
b7562e9
Compare
leavauchier
force-pushed
the
fix-docker-image
branch
3 times, most recently
from
aaf0787
to
065a57a
Compare
leavauchier
force-pushed
the
fix-docker-image
branch
from
065a57a
to
ab6e533
Compare
|
LGTM! |
CharlesGaydon
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…much as possible
This should resolve docker image build issues (image not building anymore from scratch), mainly by using a prebuilt image with micromamba and cuda installed.
Add .dockerignore to ignore cached files during docker image building
Perfs: