check label is not null

IIIF-Commons · Oct 24, 2016 · ce83ceb · ce83ceb
1 parent dbe79b1
commit ce83ceb
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 21 deletions.
diff --git a/dist/iiif-metadata-component.bundle.js b/dist/iiif-metadata-component.bundle.js
diff --git a/dist/iiif-metadata-component.css b/dist/iiif-metadata-component.css
@@ -2,15 +2,9 @@ body {
   font-family: Sans-Serif;
   padding: 20px;
 }
-.iiif-metadata-component .noData {
-  padding: 0 10px 20px 10px;
-}
 .iiif-metadata-component .groups .group .header {
   font-weight: bold;
 }
-.iiif-metadata-component .groups .group .items {
-  padding: 0 10px 20px 10px;
-}
 .iiif-metadata-component .groups .group .items .header {
   color: #14a4c3;
   border-bottom: 1px solid #14a4c3;

diff --git a/dist/iiif-metadata-component.js b/dist/iiif-metadata-component.js
@@ -283,7 +283,7 @@ var IIIFComponents;
             var $label = $metadataItem.find('.label');
             var $values = $metadataItem.find('.values');
             var label = item.getLabel();
-            if (item.isRootLevel) {
+            if (label && item.isRootLevel) {
                 switch (label.toLowerCase()) {
                     case "attribution":
                         label = this.options.content.attribution;

diff --git a/dist/iiif-metadata-component.min.js b/dist/iiif-metadata-component.min.js
diff --git a/examples/css/iiif-metadata-component.css b/examples/css/iiif-metadata-component.css
@@ -2,15 +2,9 @@ body {
   font-family: Sans-Serif;
   padding: 20px;
 }
-.iiif-metadata-component .noData {
-  padding: 0 10px 20px 10px;
-}
 .iiif-metadata-component .groups .group .header {
   font-weight: bold;
 }
-.iiif-metadata-component .groups .group .items {
-  padding: 0 10px 20px 10px;
-}
 .iiif-metadata-component .groups .group .items .header {
   color: #14a4c3;
   border-bottom: 1px solid #14a4c3;

diff --git a/examples/js/iiif-metadata-component.js b/examples/js/iiif-metadata-component.js
@@ -283,7 +283,7 @@ var IIIFComponents;
             var $label = $metadataItem.find('.label');
             var $values = $metadataItem.find('.values');
             var label = item.getLabel();
-            if (item.isRootLevel) {
+            if (label && item.isRootLevel) {
                 switch (label.toLowerCase()) {
                     case "attribution":
                         label = this.options.content.attribution;

diff --git a/examples/js/manifold.bundle.js b/examples/js/manifold.bundle.js
@@ -2246,7 +2246,10 @@ var Manifesto;
         TranslationCollection.parse = function (translation, defaultLocale) {
             var tc = [];
             var t;
-            if (_isArray(translation)) {
+            if (!translation) {
+                return tc;
+            }
+            else if (_isArray(translation)) {
                 for (var i = 0; i < translation.length; i++) {
                     var value = translation[i];
                     if (_isString(value)) {

diff --git a/src/MetadataComponent.ts b/src/MetadataComponent.ts
@@ -295,7 +295,7 @@ namespace IIIFComponents {
 
             var label: string = item.getLabel();
 
-            if (item.isRootLevel) {
+            if (label && item.isRootLevel) {
                 switch (label.toLowerCase()) {
                     case "attribution":
                         label = this.options.content.attribution;

diff --git a/src/css/iiif-metadata-component.less b/src/css/iiif-metadata-component.less
@@ -1,7 +1,7 @@
 .iiif-metadata-component{
 
     .noData{
-        padding: 0 @padding-medium-horizontal (@padding-medium-vertical * 2) @padding-medium-horizontal;
+
     }
 
     .groups {
@@ -13,7 +13,6 @@
             }
 
             .items{
-                padding: 0 @padding-medium-horizontal (@padding-medium-vertical * 2) @padding-medium-horizontal;
 
                 .header {
                     color: @brand-secondary;