Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe #266 : Basic Annotation #78

Open
glenrobson opened this issue Sep 8, 2021 · 5 comments
Open

Recipe #266 : Basic Annotation #78

glenrobson opened this issue Sep 8, 2021 · 5 comments
Assignees
Labels

Comments

@glenrobson
Copy link
Member

Links

Background and Summary

This aims to be the most basic annotation example that can be built on by further examples like the #77 recipe. It is a full canvas annotation with a motivation of commenting.

Voting and changes

We welcome comments on the recipe and as well as voting +1, confused face or -1 feel free to add comments to this issue. If this issue is approved then the author will take account of the comments before we merge the branch in to the master cookbook branch.

If the recipe is rejected by the TRC then we will make the changes requested and resubmit it to a future TRC meeting. If you feel that your comments are substantial enough that the recipe should be looked at again by the TRC after the changes have been made please vote -1 (thumbs down). A confused face is treated as abstaining.

Changes to the recipe will only be made after the TRC voting process has concluded.

@glenrobson glenrobson added this to the September 2021 milestone Sep 8, 2021
@nfreire
Copy link

nfreire commented Sep 15, 2021

I'm in favour of approval.
Nevertheless, a suggestion: in the last paragraph of the implementation notes, add a link to the list of motivation defined by the Web Annotation Model

@thehabes
Copy link

Check against the Cookbook Style guide around capitalizing resource types (Manifest, Canvas, Annotation). Also, for camel words like AnnotationPage, we do Annotation Page unless explicitly referencing the value of 'type'. In favor of approval!

@thehabes
Copy link

Web Annotation Model motivations : https://www.w3.org/TR/annotation-model/#model-12
IIIF Common Motivations : https://iiif.io/api/presentation/3.0/#35-values

@regisrob
Copy link
Member

I just found two typos:

  • second sentence: "In this recipe we are annotating the full canvas..."?
  • 4th paragraph of the implementation notes: "The Annotations must have have the type Annotation"

@glenrobson
Copy link
Member Author

Issue 78 (Recipe #266 : Basic Annotation)

+1: 24 [awead brndgtl cubap dlpierce emulatingkat glenrobson hadro irv jcreel julsraemy kirschbombe ksclarke mcwhitaker mikeapp mixterj mposton-folger nfreire regisrob rentonsa shuddles thehabes tpendragon triplingual zimeon]
0: 0 []
-1: 0 []
Not TRC: 1 [mapninja]
Ineligible: 1 [gigamorph]

Result: 24 / 24 = 1.00

Super majority is in favor, issue is approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants