Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BackgroundTasks: Use "Fire & Forget" approach when starting workers as… #8147

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

mjansenDatabay
Copy link
Contributor

@mjansenDatabay mjansenDatabay commented Oct 4, 2024

…ynchronously

This PR suggests making the start of asynchronous workers for background tasks really asynchronous to ensure a "Fire & Forget" approach. This is done by setting the "Response Timeout" to 0 and by adding a ignore_user_abort(true);) on the server-side (SOAP).

@mjansenDatabay mjansenDatabay added improvement php Pull requests that update Php code labels Oct 4, 2024
@mjansenDatabay mjansenDatabay changed the title BackgroundTasks: Use "Fire & Forge" approach when starting workers as… BackgroundTasks: Use "Fire & Forget" approach when starting workers as… Oct 4, 2024
@mjansenDatabay mjansenDatabay force-pushed the improvement/10/bgtasks-async-fireforget branch from dc5af8c to 2d3776a Compare October 4, 2024 07:40
@chfsx
Copy link
Member

chfsx commented Oct 11, 2024

Thanks a lot! I seen no problem to merge this in trunk, but maybe this could be helpful in 8-9 as well. do you have any experience with this in productive releases?

@mjansenDatabay
Copy link
Contributor Author

Thanks a lot! I seen no problem to merge this in trunk, but maybe this could be helpful in 8-9 as well. do you have any experience with this in productive releases?

Hi @chfsx ,

thanks for the question: We use this in an ILIAS 6.x installation (productive system) where this solves issues with a high usage of async. background tasks, each handling complex "Learning Progress Re-calculations".

Best regards
Michael

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants