RBAC: Move getRolesByFilter to Generator #8442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kergomard
force-pushed
the
8/rbac/fix_42223
branch
from
c574c5d to
2528ec6
Compare
|
@kergomard I provided a PR against your PR-branch where I document the "Array Shape" of the return type. This could be useful for consumers, as long as we don't have DTOs or other structures/types which provide more type information for the attributes of the list entries. The syntax is supported not only by |
…type RBAC: Document "Array Shape" for "Role List Entry"
|
Jour Fixe, 25 NOV 2024: PR accepted for all maintained versions. |
kergomard
added a commit
that referenced
this pull request
Nov 25, 2024
* RBAC: Move getRolesByFilter to Generator See: https://mantis.ilias.de/view.php?id=42223 * RBAC: Document "Array Shape" for "Role List Entry" --------- Co-authored-by: mjansen <[email protected]>
kergomard
added a commit
that referenced
this pull request
Nov 25, 2024
* RBAC: Move getRolesByFilter to Generator See: https://mantis.ilias.de/view.php?id=42223 * RBAC: Document "Array Shape" for "Role List Entry" --------- Co-authored-by: mjansen <[email protected]>
kergomard
added a commit
that referenced
this pull request
Nov 25, 2024
* RBAC: Move getRolesByFilter to Generator See: https://mantis.ilias.de/view.php?id=42223 * RBAC: Document "Array Shape" for "Role List Entry" --------- Co-authored-by: mjansen <[email protected]>
|
Thank you very much! Merged and picked to ILIAS 9, ILIAS 10, and trunk. |
chfsx
pushed a commit
to srsolutionsag/ILIAS
that referenced
this pull request
Dec 3, 2024
* RBAC: Move getRolesByFilter to Generator See: https://mantis.ilias.de/view.php?id=42223 * RBAC: Document "Array Shape" for "Role List Entry" --------- Co-authored-by: mjansen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion by @mjansenDatabay in https://mantis.ilias.de/view.php?id=42223 . As this could be seen as changing the public interface of AccessControl, I ask the JF for approval.