Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS/Maps: 42840, restore missing styling for OpenLayersMap and adjust… #8477

Open
wants to merge 1 commit into
base: release_10
Choose a base branch
from

Conversation

lukastocker
Copy link
Contributor

@lukastocker lukastocker commented Nov 20, 2024

… references to the pointer.

The pointer images are now part of the public folder.

The missing styles were part of the node_module "ol" but as this module is not part of ILIAS anymore the styling was put into a new OpenLayers SCSS file. The content is identical to "ol.css" in ILIAS 9.

https://mantis.ilias.de/view.php?id=42840

Copy link
Contributor

@Amstutz Amstutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lukastocker

Two Questions:

  • Maybe check if the pngs could be replaced by svgs.
  • SCSS: Rather extensive. Is this all necessary? Can it be shortened?

kindly
@Amstutz

@lukastocker
Copy link
Contributor Author

lukastocker commented Nov 25, 2024

Hi @Amstutz ,

I just checked the available SVG's. We could use icon_pin.svg (https://github.com/ILIAS-eLearning/ILIAS/blob/release_10/components/ILIAS/UI/resources/images/standard/icon_pin.svg). I would remove the "mm_20_shadow.png" reference in the code as it's only rendering a shadow to the original pin (mm_20_blue.png).

What's your opinion about this solution?

@yvseiler
Copy link
Collaborator

Thanks @lukastocker, yes please use the icon_pin.svg image, that should be the right one.

At the next meeting with the Iconset Task Force, I will see whether we really want to use the symbol of a golf flag here, as we did with Learning Objectives, or whether we could use a classic map pin here. If so, we would replace the icon file separately, but it would have exactly the same name and path and would therefore be updated.

@Amstutz Amstutz assigned lukastocker and unassigned Amstutz Nov 26, 2024
@Amstutz
Copy link
Contributor

Amstutz commented Nov 26, 2024

Thx @yvseiler

@lukastocker I assigned this to you, feel free to reassign if the icon is replaced.

thx

@lukastocker
Copy link
Contributor Author

Note:
@yvseiler will talk about the icon following monday (2th of december 2024) with the Iconset Task Force as the icon_pin.svg's color is barely visible when used on a map.

Depending on the result of the discussion I will implement the new solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants