-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
469 update retrofit dataset #470
Conversation
Made one update to use inner join when joining with retrofit strategies and mapping; this will make sure only the building that has retrofit strategy will get computed again. Hence help with the performance. |
Encountered FutureWarning in Galveston notebook:
Just committed a fix if that's ok. Feel free to revert it if it affects anything. Some test records from my end: Good job on the hardwork! |
Thanks for the fix and thorough test! |
add additional function to update the existing inventory dataset with additional retrofit and mapping entry key information. https://github.com/IN-CORE/pyincore/pull/470/files#diff-d1b1cb98d647ccb4ebd9f558b2894472d298769fdd3c2bde8d9d4e00205e4de0R73
Since we use fiona object and looping through fiona is too slow, I used geopandas dataframe to merge and udpate; but then save to shapefile so we can resume using fiona to carry out normal fragility matching and calculation
To test:
SLC_retrofit_test.zip
Galveston_retrofit_test.zip
tests/pyincore/analyses/buildingdamage/test_buildingdamage_retrofit.py
and see results in the retrofit folderNote: