-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
557 rename monte carlo failure probability to monte carlo limit state probability #576
557 rename monte carlo failure probability to monte carlo limit state probability #576
Conversation
You raise a good question and I think for now, we should leave things as-is and raise them to the researchers to see if the output columns still make sense or if the output fields need to be renamed as well. Let's review this assuming no additional changes and we can fix it later if we don't get timely input. |
…y-to-monte-carlo-limit-state-probability
…y-to-monte-carlo-limit-state-probability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good. test run worked. approve
…y-to-monte-carlo-limit-state-probability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code runs without issue and compared to previous results. Also checked building the documentation.
There are a lot of "failure" keywords in the function name, i/o name, and internal variable names. Not sure should I change all of them to "limit state"?
Some of them won't make sense e.g. "failure_state_keys" --> "limit_state_keys"?