Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub action error in posting the container when merged to main #633

Conversation

ywkim312
Copy link
Member

@ywkim312 ywkim312 commented Nov 18, 2024

There is an error in posting the documentation docker image by github action when the branch gets merged to the main branch. The PR fixes the problem but it is not easy to test unless this PR gets merged to main. I have tested this branch by creating the branch named "main-temp" and made github action to response to the main-temp branch instead of main branch. Then, it worked successfully and posted the docker container with the correct versioning. If you check the hub.ncsa.illinois.edu and see the tag with 1, 1.20, 1.20.1, and latest, that is the result from this PR

@ywkim312 ywkim312 self-assigned this Nov 18, 2024
@ywkim312 ywkim312 linked an issue Nov 18, 2024 that may be closed by this pull request
@ywkim312 ywkim312 marked this pull request as draft November 18, 2024 20:49
@ywkim312 ywkim312 marked this pull request as ready for review November 20, 2024 16:17
@longshuicy longshuicy merged commit 3ca7072 into develop Dec 2, 2024
7 checks passed
@longshuicy longshuicy deleted the 631-fix-github-action-error-in-posting-the-container-when-merged-to-main branch December 2, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix github action error in posting the container when merged to main
3 participants