This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Fix strftime format string #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lines 28 and 29 that were using `.strftime('%s')` where it should be written as `.strftime('%S')`. This error would make twint fail with an `Invalid format string` when using time-related configurations like `Since` and `Until`.
As we are looking for the timestamp version of the provided date/time string, using `timestamp()` should be more straightforward and shouldn't create any incompatibility issues as twint already requires Python >= 3.6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lines 28 and 29 that were using
.strftime('%s')where it should be written as.strftime('%S'). This error would make twint fail with anInvalid format stringwhen using time-related configurations likeSinceandUntil.