209-in-situ-vis #210
Open
209-in-situ-vis #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Open
* adding mesage of imported targets from catalyst * link catalyst against IPPL (need to put that in an if clause) * include "catalyst.hpp" in ChargedParticles
* error if find_path imports to GLOBAL * link error if catalyst::catalyst
In order to link against catalyst::catalyst, the find_package needs to provide the GLOBAL keyword. Then linkage, is working as well as the headers are found properly. However the GLOBAL keyword is only available by CMake>=3.24 therefore also the bump up in the cmake_minimum_required.
* add preprocessor macro to enable the catalyst.hpp only when ENABLE_CATALYST is set * add condition to linkage against IPPL which is only performed if ENABLE_CATALYST * some messages added about catalyst direction if it is found
* following CMakeLists pattern similar to cbb9de5
As a starting point the TestFieldBC structure will be used to write the adaptor and have a hopefully working executable
In order to not require the GLOBAL keyword and keep the imported targets local find_package(catalyst) is moved to the lower list. Then catalyst::catalyst is available and can be used for linkage. Using cmake-generator-expression [0] to only include compile definition as well as linkage if the ENABLE_CATALYST flag is set, otherwise the return an empy string. This prevents from tidious IF .. ELSEIF .. ENDIF construct for linkage. [0] : https://cmake.org/cmake/help/latest/manual/cmake-generator-expressions.7.html
No need for manually defining empty string in the link process, as that is handled by the CMake generator expression.
Able to print time and cycle over in-situ catalyst script.
Hard coded three dimensional mesh topology.
* remove commented out code * add positions for rho_m and E_m to penning trap * add minor comments about why it is done like that
srikrrish
added
the
feature request
* remove TestCatalystAdaptor_2D * update PenningTrap
In #e414f19 the lines from https://github.com/IPPL-framework/ippl/blob/3c74adc1056c94827a960ba535a9a0839c6ef6d2/alpine/ChargedParticles.hpp#L415-L419 where deleted, as they should be there this commit reverts that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a Paraview based in-situ visualization interface in IPPL