-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
115 - Create use case to get a file #119
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I just have questions about how we will handle versioning.
@ekraffmiller, I think I might need to assign this to myself again after reading this explanation. It seems that files do not have versions. Therefore, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The addition of datasetVersion parameter looks good, approved! Thanks for clarifying that.
@MellyGray Can you please solve merge conflicts? |
…vascript into feature/115-create-use-case-to-get-a-file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This PR adds a new use case
getFile
to the module to get a file given its id or persistentId and an optional datasetVersion.Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
The API needs to be extended to accept the datasetVersion parameter, so for the moment this use case will throw a Not Implemented Yet error when the user specifies a datasetVersion different than draft or latest.
Suggestions on how to test this:
Is there a release notes update needed for this change?
getFile use cases added to the module to get a file given its id or persistentId and an optional datasetVersion
Additional documentation: