Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

117- Create use case to get the file citation #125

Merged
merged 5 commits into from
Feb 19, 2024

Conversation

MellyGray
Copy link
Contributor

What this PR does / why we need it:

This PR adds a new use case getFileCitation to get the file citation given the fileId and datasetVersion.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

  1. Visual inspection of the code
  2. Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

GetFileCitation use case added to the module

Additional documentation:

@MellyGray MellyGray added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: File Page Waiting labels Feb 7, 2024
@MellyGray
Copy link
Contributor Author

Waiting on IQSS/dataverse#10240

@ekraffmiller ekraffmiller self-assigned this Feb 14, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! I just have a question about what dataset version should be returned by default, it seems that JSF returns :latest-published, but we are returning :latest. See Slack thread https://iqss.slack.com/archives/C06FWJ0FV2R/p1707935795390489

@MellyGray
Copy link
Contributor Author

@ekraffmiller I updated the code to set :latest-published as the default version to match JSF behavior as you suggested

@ekraffmiller
Copy link
Contributor

@MellyGray since we are creating an action item for fixing the default version shown as discussed here https://iqss.slack.com/archives/C06FWJ0FV2R/p1708016216373459, I think it's ok to keep everything as :latest, what do you think? Since our ultimate solution will be changing this logic anyway.

@pdurbin
Copy link
Member

pdurbin commented Feb 16, 2024

I'm removing the waiting label because this pull request was just merged:

@pdurbin pdurbin removed the Waiting label Feb 16, 2024
@MellyGray MellyGray assigned ekraffmiller and unassigned MellyGray Feb 16, 2024
Copy link
Contributor

@ekraffmiller ekraffmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved!

@ekraffmiller ekraffmiller removed their assignment Feb 16, 2024
@GPortas GPortas self-assigned this Feb 19, 2024
Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GPortas GPortas merged commit 3262621 into develop Feb 19, 2024
2 checks passed
@GPortas GPortas deleted the feature/117-create-use-case-to-get-the-file-citation branch February 19, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create use case to get the file citation
4 participants