-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
117- Create use case to get the file citation #125
117- Create use case to get the file citation #125
Conversation
Waiting on IQSS/dataverse#10240 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I just have a question about what dataset version should be returned by default, it seems that JSF returns :latest-published, but we are returning :latest. See Slack thread https://iqss.slack.com/archives/C06FWJ0FV2R/p1707935795390489
@ekraffmiller I updated the code to set :latest-published as the default version to match JSF behavior as you suggested |
@MellyGray since we are creating an action item for fixing the default version shown as discussed here https://iqss.slack.com/archives/C06FWJ0FV2R/p1708016216373459, I think it's ok to keep everything as :latest, what do you think? Since our ultimate solution will be changing this logic anyway. |
I'm removing the waiting label because this pull request was just merged: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, approved!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This PR adds a new use case getFileCitation to get the file citation given the fileId and datasetVersion.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
GetFileCitation use case added to the module
Additional documentation: