Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getCollection use case and tests #134

Merged
merged 19 commits into from
Mar 28, 2024

Conversation

M27Mangan
Copy link

@M27Mangan M27Mangan commented Mar 14, 2024

What this PR does / why we need it:

We need to implement a use case in the package for retrieving a collection. This use case will be utilized on the Collection page of the SPA.

Currently, for the SPA, we require the following properties to be added to the new collection model: name, affiliation, description, and owner information. Additionally, we need to map any other properties present in the API response payload that might be useful for any package consumer.

Which issue(s) this PR closes:

Related Dataverse PRs:

Special notes for your reviewer:

Suggestions on how to test this:

Visual inspection and GitHub action review

Is there a release notes update needed for this change?:

GetCollection use case added to the module

Additional documentation:

Added documentation to READMEs

@M27Mangan M27Mangan self-assigned this Mar 14, 2024
@M27Mangan M27Mangan marked this pull request as ready for review March 14, 2024 20:05
@M27Mangan M27Mangan added Size: 3 A percentage of a sprint. 2.1 hours. pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows SPA: Collection Page labels Mar 14, 2024
@M27Mangan M27Mangan removed their assignment Mar 14, 2024
@MellyGray MellyGray self-assigned this Mar 19, 2024
docs/useCases.md Outdated Show resolved Hide resolved
docs/useCases.md Outdated Show resolved Hide resolved
src/collections/domain/models/Collection.ts Outdated Show resolved Hide resolved
src/collections/domain/useCases/GetCollection.ts Outdated Show resolved Hide resolved
src/collections/domain/useCases/GetCollection.ts Outdated Show resolved Hide resolved
test/unit/collections/GetCollection.test.ts Show resolved Hide resolved
test/integration/collections/CollectionsRepository.test.ts Outdated Show resolved Hide resolved
src/collections/domain/models/Collection.ts Outdated Show resolved Hide resolved
@M27Mangan
Copy link
Author

@GPortas if you updated any of your .gitignore configs for this repo, please let me know. Seem to be adding a few unintentional files.

@MellyGray MellyGray changed the base branch from develop to fix/create_dataset_use_case March 20, 2024 08:47
@MellyGray MellyGray assigned MellyGray and unassigned M27Mangan Mar 21, 2024
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the requested changes. I added a few more comments for some small improvements

docs/useCases.md Outdated Show resolved Hide resolved
src/collections/domain/models/Collection.ts Outdated Show resolved Hide resolved
src/collections/domain/useCases/GetCollection.ts Outdated Show resolved Hide resolved
src/core/infra/repositories/ApiRepository.ts Show resolved Hide resolved
test/unit/collections/CollectionsRepository.test.ts Outdated Show resolved Hide resolved
test/unit/collections/CollectionsRepository.test.ts Outdated Show resolved Hide resolved
Base automatically changed from fix/create_dataset_use_case to develop March 22, 2024 10:01
@MellyGray MellyGray assigned M27Mangan and MellyGray and unassigned MellyGray and M27Mangan Mar 22, 2024
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MellyGray MellyGray removed their assignment Mar 25, 2024
@ekraffmiller ekraffmiller self-assigned this Mar 25, 2024
@MellyGray
Copy link
Contributor

@ekraffmiller I reran the tests to ensure they were still passing, but now the publish action is failing because it attempted to publish the same version again. 😆 It should be fine, just ignore the failing step

@ekraffmiller ekraffmiller assigned GPortas and unassigned ekraffmiller Mar 26, 2024
@ekraffmiller
Copy link
Contributor

@GPortas this looks good, but is it ok that the publish-gpr is failing?
Screenshot 2024-03-27 at 1 08 40 PM

@GPortas
Copy link
Contributor

GPortas commented Mar 28, 2024

@GPortas this looks good, but is it ok that the publish-gpr is failing?

Yes, since Melina manually re-executed the GitHub action, please take a look at her comment @ekraffmiller.

@ekraffmiller I reran the tests to ensure they were still passing, but now the publish action is failing because it attempted to publish the same version again. 😆 It should be fine, just ignore the failing step

Copy link
Contributor

@GPortas GPortas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@GPortas GPortas merged commit e0438a2 into develop Mar 28, 2024
4 of 5 checks passed
@GPortas GPortas deleted the feature/131-create-getcollection-use-case branch March 28, 2024 10:14
@GPortas GPortas removed their assignment Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pm.GREI-d-2.7.1 NIH, yr2, aim7, task1: R&D UI modules for creating datasets and supporting publishing workflows pm.GREI-d-2.7.2 NIH, yr2, aim7, task2: Implement UI modules for creating datasets and publishing workflows Size: 3 A percentage of a sprint. 2.1 hours. SPA: Collection Page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create GetCollection use case
4 participants