-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getCollection use case and tests #134
Conversation
…, removed placeholder content
src/collections/infra/repositories/transformers/collectionTransformers.ts
Outdated
Show resolved
Hide resolved
…aned up useCases docs.
…tcollection-use-case
@GPortas if you updated any of your .gitignore configs for this repo, please let me know. Seem to be adding a few unintentional files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the requested changes. I added a few more comments for some small improvements
src/collections/infra/repositories/transformers/CollectionPayload.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@ekraffmiller I reran the tests to ensure they were still passing, but now the publish action is failing because it attempted to publish the same version again. 😆 It should be fine, just ignore the failing step |
@GPortas this looks good, but is it ok that the publish-gpr is failing? |
Yes, since Melina manually re-executed the GitHub action, please take a look at her comment @ekraffmiller.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What this PR does / why we need it:
We need to implement a use case in the package for retrieving a collection. This use case will be utilized on the Collection page of the SPA.
Currently, for the SPA, we require the following properties to be added to the new collection model: name, affiliation, description, and owner information. Additionally, we need to map any other properties present in the API response payload that might be useful for any package consumer.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Visual inspection and GitHub action review
Is there a release notes update needed for this change?:
GetCollection use case added to the module
Additional documentation:
Added documentation to READMEs