fix Dataverse UI ability to set GB at request param

IQSS · Sep 20, 2023 · 3ad53d7 · 3ad53d7
1 parent d06259f
commit 3ad53d7
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/src/main/java/edu/harvard/iq/dataverse/DvObjectContainer.java b/src/main/java/edu/harvard/iq/dataverse/DvObjectContainer.java
@@ -116,12 +116,15 @@ public boolean getEffectiveGuestbookEntryAtRequest() {
         return gbAtRequest;
     }
 
-    public Boolean getGuestbookEntryAtRequest() {
-        return guestbookAtRequest;
+    public String getGuestbookEntryAtRequest() {
+        if(guestbookAtRequest==null) {
+            return UNDEFINED_CODE;
+        }
+        return Boolean.valueOf(guestbookAtRequest).toString();
     }
 
     public void setGuestbookEntryAtRequest(String gbAtRequest) {
-        if (gbAtRequest != null && gbAtRequest.equals(UNDEFINED_CODE)) {
+        if (gbAtRequest == null || gbAtRequest.equals(UNDEFINED_CODE)) {
             this.guestbookAtRequest = null;
         } else {
             //Force to true or false

diff --git a/src/main/java/edu/harvard/iq/dataverse/SettingsWrapper.java b/src/main/java/edu/harvard/iq/dataverse/SettingsWrapper.java
@@ -649,7 +649,7 @@ public Map<String, String> getGuestbookEntryOptions(DvObjectContainer target) {
                 useDefault = (defaultOption ? atRequest : atDownload)
                         + BundleUtil.getStringFromBundle("dataverse.inherited");
             }
-            currentMap.put("null", useDefault);
+            currentMap.put(DvObjectContainer.UNDEFINED_CODE, useDefault);
             currentMap.put(Boolean.toString(true), atRequest);
             currentMap.put(Boolean.toString(false), atDownload);
         } else {

diff --git a/src/main/java/edu/harvard/iq/dataverse/api/Datasets.java b/src/main/java/edu/harvard/iq/dataverse/api/Datasets.java
@@ -3888,8 +3888,8 @@ public Response getGuestbookEntryOption(@Context ContainerRequestContext crc, @P
         } catch (WrappedResponse ex) {
             return error(Response.Status.NOT_FOUND, "No such dataset");
         }
-        Boolean gbAtRequest = dataset.getGuestbookEntryAtRequest();
-        if(gbAtRequest == null) {
+        String gbAtRequest = dataset.getGuestbookEntryAtRequest();
+        if(gbAtRequest == null || gbAtRequest.equals(DvObjectContainer.UNDEFINED_CODE)) {
             return ok("Not set on dataset, using the default: " + dataset.getEffectiveGuestbookEntryAtRequest());
         }
         return ok(dataset.getEffectiveGuestbookEntryAtRequest());