Skip to content

Commit

Permalink
Merge pull request #9977 from Sakshi-75/equals-method-fix
Browse files Browse the repository at this point in the history
Equals method fix
  • Loading branch information
kcondon authored Oct 11, 2023
2 parents d5036ba + f42587e commit 892073c
Show file tree
Hide file tree
Showing 10 changed files with 240 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ public int hashCode() {

@Override
public boolean equals(Object object) {
if (!(object instanceof DatasetField)) {
if (!(object instanceof DatasetFieldDefaultValue)) {
return false;
}
DatasetFieldDefaultValue other = (DatasetFieldDefaultValue) object;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ public int hashCode() {

@Override
public boolean equals(Object object) {
if (!(object instanceof DatasetFieldType)) {
if (!(object instanceof DataverseContact)) {
return false;
}
DataverseContact other = (DataverseContact) object;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/DataverseFacet.java
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ public int hashCode() {

@Override
public boolean equals(Object object) {
if (!(object instanceof DatasetFieldType)) {
if (!(object instanceof DataverseFacet)) {
return false;
}
DataverseFacet other = (DataverseFacet) object;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public int hashCode() {

@Override
public boolean equals(Object object) {
if (!(object instanceof DatasetFieldType)) {
if (!(object instanceof DataverseFeaturedDataverse)) {
return false;
}
DataverseFeaturedDataverse other = (DataverseFeaturedDataverse) object;
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/edu/harvard/iq/dataverse/DataverseTheme.java
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ public int hashCode() {

@Override
public boolean equals(Object object) {
if (!(object instanceof DatasetFieldType)) {
if (!(object instanceof DataverseTheme)) {
return false;
}
DataverseTheme other = (DataverseTheme) object;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package edu.harvard.iq.dataverse;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import org.junit.jupiter.api.BeforeEach;

public class DatasetFieldDefaultValueTest {
private DatasetFieldDefaultValue dataverseContact;

@BeforeEach
public void before() {
this.dataverseContact = new DatasetFieldDefaultValue();
this.dataverseContact.setId(1L);
}

@Test
public void testEqualsWithNull() {
assertFalse(this.dataverseContact.equals(null));
}

@Test
public void testEqualsWithDifferentClass() {
DatasetField datasetField = new DatasetField();

assertFalse(this.dataverseContact.equals(datasetField));
}

@Test
public void testEqualsWithSameClassSameId() {
DatasetFieldDefaultValue dataverseContact1 = new DatasetFieldDefaultValue();
dataverseContact1.setId(1L);

assertTrue(this.dataverseContact.equals(dataverseContact1));
}

@Test
public void testEqualsWithSameClassDifferentId() {
DatasetFieldDefaultValue dataverseContact1 = new DatasetFieldDefaultValue();
dataverseContact1.setId(2L);

assertFalse(this.dataverseContact.equals(dataverseContact1));
}
}
47 changes: 47 additions & 0 deletions src/test/java/edu/harvard/iq/dataverse/DataverseContactTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package edu.harvard.iq.dataverse;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import org.junit.jupiter.api.BeforeEach;

public class DataverseContactTest {
private DataverseContact dataverseContact;

@BeforeEach
public void before() {
this.dataverseContact = new DataverseContact();
this.dataverseContact.setId(1L);
}

@Test
public void testEqualsWithNull() {
assertFalse(this.dataverseContact.equals(null));
}

@Test
public void testEqualsWithDifferentClass() {
DatasetFieldType datasetFieldType = new DatasetFieldType();

assertFalse(this.dataverseContact.equals(datasetFieldType));
}

@Test
public void testEqualsWithSameClassSameId() {
DataverseContact dataverseContact1 = new DataverseContact();
dataverseContact1.setId(1L);

assertTrue(this.dataverseContact.equals(dataverseContact1));
}

@Test
public void testEqualsWithSameClassDifferentId() {
DataverseContact dataverseContact1 = new DataverseContact();
dataverseContact1.setId(2L);

assertFalse(this.dataverseContact.equals(dataverseContact1));
}
}
47 changes: 47 additions & 0 deletions src/test/java/edu/harvard/iq/dataverse/DataverseFacetTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package edu.harvard.iq.dataverse;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import org.junit.jupiter.api.BeforeEach;

public class DataverseFacetTest {
private DataverseFacet dataverseFacet;

@BeforeEach
public void before() {
this.dataverseFacet = new DataverseFacet();
this.dataverseFacet.setId(1L);
}

@Test
public void testEqualsWithNull() {
assertFalse(this.dataverseFacet.equals(null));
}

@Test
public void testEqualsWithDifferentClass() {
DatasetFieldType datasetFieldType = new DatasetFieldType();

assertFalse(this.dataverseFacet.equals(datasetFieldType));
}

@Test
public void testEqualsWithSameClassSameId() {
DataverseFacet dataverseFacet1 = new DataverseFacet();
dataverseFacet1.setId(1L);

assertTrue(this.dataverseFacet.equals(dataverseFacet1));
}

@Test
public void testEqualsWithSameClassDifferentId() {
DataverseFacet dataverseFacet1 = new DataverseFacet();
dataverseFacet1.setId(2L);

assertFalse(this.dataverseFacet.equals(dataverseFacet1));
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package edu.harvard.iq.dataverse;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import org.junit.jupiter.api.BeforeEach;

public class DataverseFeaturedDataverseTest {
private DataverseFeaturedDataverse dataverseFeaturedDataverse;

@BeforeEach
public void before() {
this.dataverseFeaturedDataverse = new DataverseFeaturedDataverse();
this.dataverseFeaturedDataverse.setId(1L);
}

@Test
public void testEqualsWithNull() {
assertFalse(this.dataverseFeaturedDataverse.equals(null));
}

@Test
public void testEqualsWithDifferentClass() {
DatasetFieldType datasetFieldType = new DatasetFieldType();

assertFalse(this.dataverseFeaturedDataverse.equals(datasetFieldType));
}

@Test
public void testEqualsWithSameClassSameId() {
DataverseFeaturedDataverse dataverseFeaturedDataverse1 = new DataverseFeaturedDataverse();
dataverseFeaturedDataverse1.setId(1L);

assertTrue(this.dataverseFeaturedDataverse.equals(dataverseFeaturedDataverse1));
}

@Test
public void testEqualsWithSameClassDifferentId() {
DataverseFeaturedDataverse dataverseFeaturedDataverse1 = new DataverseFeaturedDataverse();
dataverseFeaturedDataverse1.setId(2L);

assertFalse(this.dataverseFeaturedDataverse.equals(dataverseFeaturedDataverse1));
}
}
47 changes: 47 additions & 0 deletions src/test/java/edu/harvard/iq/dataverse/DataverseThemeTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package edu.harvard.iq.dataverse;

import org.junit.jupiter.api.Test;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertTrue;
import static org.junit.jupiter.api.Assertions.assertFalse;

import org.junit.jupiter.api.BeforeEach;

public class DataverseThemeTest {
private DataverseTheme dataverseTheme;

@BeforeEach
public void before() {
this.dataverseTheme = new DataverseTheme();
this.dataverseTheme.setId(1L);
}

@Test
public void testEqualsWithNull() {
assertFalse(this.dataverseTheme.equals(null));
}

@Test
public void testEqualsWithDifferentClass() {
DatasetFieldType datasetFieldType = new DatasetFieldType();

assertFalse(this.dataverseTheme.equals(datasetFieldType));
}

@Test
public void testEqualsWithSameClassSameId() {
DataverseTheme dataverseTheme1 = new DataverseTheme();
dataverseTheme1.setId(1L);

assertTrue(this.dataverseTheme.equals(dataverseTheme1));
}

@Test
public void testEqualsWithSameClassDifferentId() {
DataverseTheme dataverseTheme1 = new DataverseTheme();
dataverseTheme1.setId(2L);

assertFalse(this.dataverseTheme.equals(dataverseTheme1));
}
}

0 comments on commit 892073c

Please sign in to comment.