Skip to content

Commit

Permalink
update of the keywordVocabularyURI metadata to make it consistent wit…
Browse files Browse the repository at this point in the history 
…h its name Controlled Vocabulary URL
  • Loading branch information
@stevenferey
stevenferey committed Feb 7, 2024
1 parent a5f4bd7 commit 9f72845
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion scripts/api/data/metadatablocks/citation.tsv
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
keywordValue Term A key term that describes important aspects of the Dataset text 21 #VALUE TRUE FALSE FALSE TRUE TRUE FALSE keyword citation
keywordTermURI Term URI Keyword URI points to the web presence of the term. Enter an absolute URI, starting by https:// https:// url 22 <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE FALSE FALSE TRUE FALSE keyword citation
keywordVocabulary Controlled Vocabulary Name The controlled vocabulary used for the keyword term (e.g. LCSH, MeSH) text 23 (#VALUE) FALSE FALSE FALSE FALSE TRUE FALSE keyword citation
keywordVocabularyURI Controlled Vocabulary URL The URL where one can access information about the term's controlled vocabulary https:// url 24 <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE FALSE FALSE TRUE FALSE keyword citation
keywordVocabularyURL Controlled Vocabulary URL The URL where one can access information about the term's controlled vocabulary https:// url 24 <a href="#VALUE" target="_blank" rel="noopener">#VALUE</a> FALSE FALSE FALSE FALSE TRUE FALSE keyword citation
topicClassification Topic Classification Indicates a broad, important topic or subject that the Dataset covers and information about any controlled vocabulary used none 25 FALSE FALSE TRUE FALSE FALSE FALSE citation
topicClassValue Term A topic or subject term text 26 #VALUE TRUE FALSE FALSE TRUE FALSE FALSE topicClassification citation
topicClassVocab Controlled Vocabulary Name The controlled vocabulary used for the keyword term (e.g. LCSH, MeSH) text 27 (#VALUE) FALSE FALSE FALSE FALSE FALSE FALSE topicClassification citation
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/propertyFiles/citation.properties
View file
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ datasetfieldtype.keyword.title=Keyword
datasetfieldtype.keywordTermURI.title=Term URI
datasetfieldtype.keywordValue.title=Term
datasetfieldtype.keywordVocabulary.title=Controlled Vocabulary Name
datasetfieldtype.keywordVocabularyURI.title=Controlled Vocabulary URL
datasetfieldtype.keywordVocabularyURL.title=Controlled Vocabulary URL
datasetfieldtype.topicClassification.title=Topic Classification
datasetfieldtype.topicClassValue.title=Term
datasetfieldtype.topicClassVocab.title=Controlled Vocabulary Name
Expand Down
5 changes: 5 additions & 0 deletions src/main/resources/db/migration/V6.1.0.2__10288-update_keywordVocabularyURI_metadata.sql
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
-- update of the "keywordVocabularyURI" metadata to make it consistent with its name "Controlled Vocabulary URL"
UPDATE datasetfieldtype SET name = 'keywordVocabularyURL'
WHERE name = 'keywordVocabularyURI'
AND parentdatasetfieldtype_id = (
SELECT id FROM datasetfieldtype WHERE name = 'keyword') ;

2 comments on commit 9f72845

@luddaniel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Peut être pas suffisant pour la feature :
    keywordValue pouvait accueillir des "prefLabel" ou des "termUri", donc des libellés ou des ID. Maintenant on fait la différence entre les 2 avec le nouveau champ keywordTermURI.
    Peut se poser la question de migrer la donnée de keywordValue à keywordTermURI si keywordValue like 'http%'
select value from datasetfieldvalue dfv
inner join datasetfield df on df.id = dfv.datasetfield_id 
where df.datasetfieldtype_id = (select id from datasetfieldtype where name = 'keywordValue')
and value like 'http%';
  1. on est d'accord que nous on doit passer de keywordTermURL à keywordTermURI ?

@stevenferey
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Peut être pas suffisant pour la feature :
    keywordValue pouvait accueillir des "prefLabel" ou des "termUri", donc des libellés ou des ID. Maintenant on fait la différence entre les 2 avec le nouveau champ keywordTermURI.
    Peut se poser la question de migrer la donnée de keywordValue à keywordTermURI si keywordValue like 'http%'
select value from datasetfieldvalue dfv
inner join datasetfield df on df.id = dfv.datasetfield_id 
where df.datasetfieldtype_id = (select id from datasetfieldtype where name = 'keywordValue')
and value like 'http%';
2. on est d'accord que nous on doit passer de keywordTermURL à keywordTermURI ?

Le select et l'update est intégré à la doc, dans le .md
Concernant la modification de la métadonnée coté Recherche Data Gouv de keywordTermURL à keywordTermURI, oui c'est bien ce qui est prévu (sujet spécifique à l'équipe)

Please sign in to comment.