Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable ConfigCheckServiceTest #10025

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

pdurbin
Copy link
Member

@pdurbin pdurbin commented Oct 18, 2023

@github-actions

This comment has been minimized.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 18, 2023

It failed with this:

TASK [dataverse : fire off installer] ****************************************** fatal: [localhost]: FAILED! => {"changed": true, "cmd": "/usr/bin/python3 /tmp/dvinstall/install.py -f --config_file=default.config --noninteractive > /tmp/dvinstall/install.out 2>&1", "delta": "0:02:17.692851", "end": "2023-10-18 20:37:55.704422", "msg": "non-zero return code", "rc": 1, "start": "2023-10-18 20:35:38.011571", "stderr": "", "stderr_lines": [], "stdout": "", "stdout_lines": []}

From https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10025/1/consoleText

@pdurbin pdurbin added the Size: 3 A percentage of a sprint. 2.1 hours. label Oct 26, 2023
@pdurbin pdurbin self-assigned this Oct 26, 2023
Jenkins is failing. Maybe disabling this will help.

It was added in this PR: #9819
@pdurbin pdurbin force-pushed the 10024-disable-config-check-service-test branch from 41b0d3a to b9f7709 Compare October 26, 2023 17:49
Copy link
Member

@qqmyers qqmyers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kcondon kcondon assigned kcondon and unassigned pdurbin Oct 26, 2023
@pdurbin pdurbin marked this pull request as ready for review October 26, 2023 18:09
@github-actions
Copy link

📦 Pushed preview images as

ghcr.io/gdcc/dataverse:10024-disable-config-check-service-test
ghcr.io/gdcc/configbaker:10024-disable-config-check-service-test

🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name.

@pdurbin
Copy link
Member Author

pdurbin commented Oct 26, 2023

I'm hoping this passes: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-10025/4/

@poikilotherm heads up that we just discussed this during the sprint kickoff, reviewing and merging this PR. We assume that a new issue is required to re-enable these tests (once this has been merged).

@kcondon kcondon merged commit 4226b55 into develop Oct 26, 2023
15 checks passed
@kcondon kcondon deleted the 10024-disable-config-check-service-test branch October 26, 2023 18:42
@pdurbin pdurbin added this to the 6.1 milestone Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Size: 3 A percentage of a sprint. 2.1 hours.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review and fix current failing tests (EC2 spin up failing)
3 participants