IQSS/10516 fix perma legacy support #10521
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qqmyers
added
the
Consider For Next Release
cmbz
added
FY25 Sprint 8
stevenwinship
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Fixes handling of legacy permalink configuration after the multi pid upgrade. Two underlying issues: base-url wasn't optional as it used to be and the identification of a legacy perma provider for a give PID was broken due to use of the wrong default separator.
Which issue(s) this PR closes:
Closes #10516
Special notes for your reviewer:
Suggestions on how to test this: Setup a legacy perma config using :Authority, :Shoulder, :Protocol and confirm it works (Dataverse starts, can create/publish datasets). Note that now that Dataverse requires a valid PID config to start and you can't use the settings API until Dataverse has started, you either need to configure and then remove a multipid config, or update the settings in the DB directly.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: added
Additional documentation: