Adding terms of use in DDI #11071
Open
Adding terms of use in DDI #11071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sekmiller
reviewed
Dec 13, 2024
| xmlw.writeCharacters(version.getTermsOfUse()); | ||
| xmlw.writeEndElement(); //notes | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add to DdiExportUtilTest.java to exercise this code?
There was a problem hiding this comment.
Added dataset-finch-terms-of-use.json and dataset-finch-terms-of-use.xml which is used in testJson2DdiNoFilesTermsOfUse() for custom terms of use
sekmiller
reviewed
Dec 13, 2024
| xmlw.writeCharacters("<a href=" + '"' + uri + '"' + ">" + name + "</a>"); | ||
| xmlw.writeEndElement(); //notes | ||
| } | ||
| } |
There was a problem hiding this comment.
Also, please add a test to DdiExportUtilTest.java
There was a problem hiding this comment.
The standard license was already in dataset-finch1.json and dataset-finch1.xml was updated to add the standard license.
sekmiller
requested changes
Dec 13, 2024
|
@sekmiller I updated the branch from the develop and added to the DdiExportUtilTest to test for standard license and custom terms of use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It adds custom terms of use and standard license in DDI export.
It adds standard license to DDI import.
In this case DDI import and export match and will include both standard and custom licenses.
Which issue(s) this PR closes:
Suggestions on how to test this:
Create two datasets, one with standard license and another custom license. Publish it. Look at export DDI. For standard license it should contain something like:
<dataAccs> <notes type="DVN:TOU" level="dv"> <a href="http://creativecommons.org/publicdomain/zero/1.0">CC0 1.0</a> </notes> </dataAccs>For custom license, it should contain something like:
<dataAccs><notes type="DVN:TOU" level="dv">This is my terms</notes></dataAccs>Then try to create a new datasets with these DDI xmls using importddi api. See that for standard license it appears as standard and custom Terms of use appear as custom.