-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
include total_count_per_object_type in search response #11082
base: develop
Are you sure you want to change the base?
include total_count_per_object_type in search response #11082
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hi @stevenwinship , the count returned should be on the total number of items found but not on the basis of what is returned according to the pagination, is it implemented like that? |
Fixed counts to be all results and not just a pages worth
|
This comment has been minimized.
This comment has been minimized.
1 similar comment
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
What this PR does / why we need it: SPA Collection Page needs to show counts of the files, datasets, and collections (dataverses) in the results
Which issue(s) this PR closes:#11065
Special notes for your reviewer:
Suggestions on how to test this: See SearchIT
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: Included
Additional documentation: