4685 ui toggle for language selection #4789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest French translation - Consolidation
…685-UI-toggle-for-language-selection # Conflicts: # src/main/java/Bundle_fr.properties
|
@JayanthyChengan I have not had a chance today to review the UI for this, but hope to get to this as my next task. |
…ggle-for-language-selection
|
|
||
| } | ||
|
|
||
| private static String readUrl(String urlString) throws Exception { |
There was a problem hiding this comment.
could any tests be added for this?
There was a problem hiding this comment.
I tested the workflow only with logger messages.
|
Closed as superseded by the other PR for this. |
|
That other PR being #4841. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR in reference to the issue: #4685
@pdurbin
@mheppler
added by @pdurbin to associate the pull request with the issue in Waffle
connects to #4685