Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify note about Basic File Access in API Guide #9690

Conversation

KimJinYeon
Copy link
Contributor

@KimJinYeon KimJinYeon commented Jul 3, 2023

What this PR does / why we need it:

https://guides.dataverse.org/en/latest/api/dataaccess.html
https://guides.dataverse.org/en/latest/installation/config.html?highlight=pidsenabled

Note at Basic File Access should clarify that FilePIDsEnabled should be turned on to access file by PIDs.
Otherwise, file access by PID would not work.

Which issue(s) this PR closes:

Special notes for your reviewer:

None.

Suggestions on how to test this:

None.

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

None.

Is there a release notes update needed for this change?:

None.

Additional documentation:

None.

Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but let's use a ref.

doc/sphinx-guides/source/api/dataaccess.rst Outdated Show resolved Hide resolved
Copy link
Member

@pdurbin pdurbin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jggautier
Copy link
Contributor

jggautier commented Sep 19, 2023

Is this true for an installation that has files with PIDs but its :FilePIDsEnabled setting is disabled?

This is the case for at least Harvard Dataverse, and maybe other installations where some files have PIDs and some don't, and I'm able to use the file access endpoint with the persistentId parameter to get the files using their PIDs.

@pdurbin pdurbin added Feature: API Guide Size: 0.5 A percentage of a sprint. 0.35 hours labels Sep 19, 2023
@pdurbin pdurbin changed the title Clarify note at Basic File Aceess Documentation Clarify note about Basic File Access in API Guide Sep 19, 2023
@kcondon kcondon self-assigned this Sep 19, 2023
@kcondon kcondon merged commit e5f4e82 into IQSS:develop Sep 19, 2023
1 check passed
@pdurbin pdurbin added this to the 6.1 milestone Sep 19, 2023
@pdurbin
Copy link
Member

pdurbin commented Sep 19, 2023

Well, if a file has a PID, it can be used. The spirit of the doc improvement it to raise consciousness that files may or may not have a PID. Overall, I think it helps.

@jggautier
Copy link
Contributor

Cool okay. Thanks. I don't think that's what's being said if it's taken literally. But I agree it's an improvement 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: API Guide Size: 0.5 A percentage of a sprint. 0.35 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request/Idea: Description about Basic File Access at Data Access docs should be clarified
6 participants