Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce logging for download file guestbook/terms bug #9863

Closed
wants to merge 2 commits into from
Closed

reduce logging for download file guestbook/terms bug #9863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca31290
reduce logging for download file guestbook/terms bug #9806
pdurbin Aug 30, 2023
f30316d
Merge branch 'develop' into 9806-logging #9806
pdurbin Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions doc/release-notes/9340-payara5to6.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,3 +130,19 @@
`sudo -u dataverse /usr/local/payara6/bin/asadmin stop-domain`

`sudo -u dataverse /usr/local/payara6/bin/asadmin start-domain`

1. Reducing logging related to third party code used with Terms of Use/Guestbook

Some third party library code is used in the UI of the application and unfortunately, in this release, it seems to be leading to excessive logging, despite everything appearing to work properly. For example, downloading a file with Terms of Use/Guestbook enabled works, but a very long exception stack trace ends up in server.log (look for `ViewHandlingStrategyNotFoundException`).

To supress these messages, the following line can be added to `/usr/local/payara6/glassfish/domains/domain1/config/logging.properties`

`jakarta.enterprise.resource.webcontainer.faces.level=OFF`

Alternatively, you can run this (it does the same thing):

`asadmin set-log-levels jakarta.enterprise.resource.webcontainer.faces=OFF`

A Payara restart should not be required.

If you'd like additional details on this bug, please see issue #9806.
2 changes: 2 additions & 0 deletions modules/container-base/src/main/docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ RUN <<EOF
${ASADMIN} create-jvm-options "-XX\:HeapDumpPath=\${ENV=DUMPS_DIR}"
# Set logging to console only for containers
${ASADMIN} set-log-attributes com.sun.enterprise.server.logging.GFFileHandler.logtoFile=false \
# Workaround for excessive logging when downloading file if guestbook: https://github.com/IQSS/dataverse/issues/9806
${ASADMIN} set-log-levels jakarta.enterprise.resource.webcontainer.faces=OFF

### PRODUCTION READINESS
${ASADMIN} create-jvm-options '-XX\:+UseG1GC'
Expand Down
3 changes: 3 additions & 0 deletions scripts/installer/as-setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ function preliminary_setup()
# Workaround for FISH-7722: Failed to deploy war with @Stateless https://github.com/payara/Payara/issues/6337
./asadmin $ASADMIN_OPTS create-jvm-options --add-opens=java.base/java.io=ALL-UNNAMED

# Workaround for excessive logging when downloading file if guestbook: https://github.com/IQSS/dataverse/issues/9806
./asadmin $ASADMIN_OPTS set-log-levels jakarta.enterprise.resource.webcontainer.faces=OFF

# enable comet support
./asadmin $ASADMIN_OPTS set server-config.network-config.protocols.protocol.http-listener-1.http.comet-support-enabled="true"

Expand Down