-
Notifications
You must be signed in to change notification settings - Fork 500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support Postgres versions 14 and 15 #9877
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't test the installer but I tested in Docker. Looks good. Approved. Thanks, Don!
This is what I wrote in Slack on Friday: To summarize, @don and I created https://github.com/gdcc/api-test-runner/actions/workflows/postgres15.yml and containerized Postgres 15 is working fine, (somewhat surprisingly) even without the "GRANT ALL ON SCHEMA public TO "+pgUser+" he added to install.py (our Docker images don’t use the installer). The version being tested in that container is PostgreSQL 15.4 (Debian 15.4-1.pgdg120+1). So yeah, I think we should be open to an issue and PR. His change to the installer is specific to PG 15:
Thanks or all the legwork, Don! Also, I looked at the docs at https://guides.dataverse.org/en/5.14/installation/prerequisites.html and we already say, "We recommend installing the latest version that is available for your OS distribution." So this PR is in line with that. All the examples use Postgres 13 and we say, "The application has been tested with PostgreSQL versions up to 13." We can change the examples when we actually are ready to move developers, test infra, and prod to Postgres 13. |
Found an issue when installing on postgres 13: |
This comment has been minimized.
This comment has been minimized.
Fixed (sorry). |
@donsizemore the fact that API tests are passing as of the second run is great: https://jenkins.dataverse.org/job/IQSS-Dataverse-Develop-PR/job/PR-9877/2/testReport/ My understanding is that PG 13 is being used for that test. What about a test for PG 15? Would you be able to set up a dedicated Jenkins job for that? If we can get that to pass, I'm comfortable merging this. For the release note, I'm thinking of something along these lines: "PostgreSQL 13 remains the tested and supported version. However, the installer and Flyway have been upgraded to support PostgreSQL 14 and 15. See PR #9877 for details." |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
📦 Pushed preview images as
🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too.
What this PR does / why we need it:
add flyway and installer support for Postgres versions 14 and 15
Which issue(s) this PR closes:
Special notes for your reviewer:
None
Suggestions on how to test this:
Install Dataverse using installer and warfile built from branch, run E2E tests.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No
Is there a release notes update needed for this change?:
Perhaps, to explain the support (but not requirement) of the newer Postgres versions.
Additional documentation:
Added: https://dataverse-guide--9877.org.readthedocs.build/en/9877/installation/prerequisites.html#postgresql