feat(ct): add labels with service dependency versions to images #9928 #9930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poikilotherm
added
the
Component: Containers
pdurbin
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
I tested this and it works fine:
$ docker inspect -f '{{ index .Config.Labels "org.dataverse.deps.solr.version"}}' gdcc/dataverse:unstable
9.3.0
$ docker inspect -f '{{ index .Config.Labels "org.dataverse.deps.postgresql.version"}}' gdcc/dataverse:unstable
13
@kcondon this is very low risk. Zero impact on the core app.
|
Can confirm! ❯ docker inspect -f '{{ index .Config.Labels "org.dataverse.deps.solr.version"}}' gdcc/dataverse:unstable
9.3.0
❯ docker inspect -f '{{ index .Config.Labels "org.dataverse.deps.postgresql.version"}}' gdcc/dataverse:unstable
13 |
JR-1991
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provide annotations/labels on Dataverse application container images carrying the information which PostgreSQL and Solr version is meant to be used with this image.
Which issue(s) this PR closes:
Special notes for your reviewer:
None. This is container metadata only, nothing else affected
Suggestions on how to test this:
Build the image, run
docker inspect -f '{{ index .Config.Labels "org.dataverse.deps.solr.version"}}' gdcc/dataverse:unstableto see the label's content.Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Nope
Is there a release notes update needed for this change?:
Nope
Additional documentation:
None