assign role using email #9963
Merged
assign role using email #9963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Give a user a role from email address of the user's account
pdurbin
reviewed
Sep 28, 2023
src/main/webapp/roles-assign.xhtml
Outdated
Comment on lines
34
to
35
| <h:outputText value="#{roleAssignee.displayInfo.title}"/> | ||
| <h:outputText value="#{roleAssignee.displayInfo.title}"/> | ||
| <h:outputText value=" - #{roleAssignee.displayInfo.emailAddress}"/> |
There was a problem hiding this comment.
@jeromeroucou I saw your note about this:
"Yes, there is a little difference from before : email addresses are now displayed next to the user's name, like this : John Doe - [email protected]. I can remove that if needed."
I'm wondering... is this potentially a privacy problem? I can discover your email address by using the "add role" feature?
There was a problem hiding this comment.
Hi @pdurbin,
Indeed, a collection administrator could discover an email address with this feature. In that case, I'll remove my proposal.
stevenwinship
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR will address the request to assign a role to others with their email addresses
Which issue(s) this PR closes:
Special notes for your reviewer:
I haven't found any unit tests for managing roles and permissions (RoleAssigneeServiceBean.java)
Suggestions on how to test this:
In the "Assign a role" modal of a collection's Permissions menu, you can search for a user by e-mail address.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes, there is a little difference from before : email addresses are now displayed next to the user's name, like this :
John Doe - [email protected]. I can remove that if needed.Is there a release notes update needed for this change?:
No
Additional documentation:
In documentation page, the first screenshot mist be updated with a Havard Dataverse collection in background